Summary: | Support tvOS and watchOS in webkitdirs.pm | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, buildbot, commit-queue, dbates, lforschler | ||||||
Priority: | P2 | ||||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Aakash Jain
2017-03-29 19:25:24 PDT
Created attachment 305823 [details]
Proposed patch
Comment on attachment 305823 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=305823&action=review > Tools/Scripts/webkitdirs.pm:469 > + if (checkForArgumentAndRemoveFromARGV("--tv-device")) { I wonder if it would be better to have "os" in the option name, for consistency with ios. > Tools/Scripts/webkitdirs.pm:1353 > + return isIOSWebKit() || isTVOSWebKit() || isWATCHOSWebKit(); Double space here. Comment on attachment 305823 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=305823&action=review > Tools/Scripts/webkitdirs.pm:105 > + TVOS => "tvOS", TVOS => tvOS > Tools/Scripts/webkitdirs.pm:106 > + WATCHOS => "watchOS", WATCHOS => watchOS > Tools/Scripts/webkitdirs.pm:471 > + $xcodeSDK ||= $hasInternalSDK ? 'appletvos.internal' : 'appletvos'; ' => " > Tools/Scripts/webkitdirs.pm:478 > + $xcodeSDK ||= $hasInternalSDK ? 'watchos.internal' : 'watchos'; Ditto. > Tools/Scripts/webkitdirs.pm:504 > + return "appletvos" if $xcodeSDK =~ /appletvos/i; Please sort the added lines. > Tools/Scripts/webkitdirs.pm:1343 > + return portName() eq TVOS; TVOS => tvOS > Tools/Scripts/webkitdirs.pm:1346 > +sub isWATCHOSWebKit() isWatchOSWebKit() > Tools/Scripts/webkitdirs.pm:1348 > + return portName() eq WATCHOS; WATCHOS => watchOS Created attachment 305905 [details]
Updated patch
Incorporated review comments.
Comment on attachment 305905 [details] Updated patch Clearing flags on attachment: 305905 Committed r214631: <http://trac.webkit.org/changeset/214631> All reviewed patches have been landed. Closing bug. Followup commit to rename isIOSLikeWebKit to isEmbeddedWebKit. https://trac.webkit.org/changeset/214957/webkit |