Bug 170182 – WebAssembly: pass Wasm::Context* to vmEntryToWasm when not using fast TLS

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Yusuke Suzuki]

And set it to wasmContext GPR.

[Saam Barati]

working on this now

[Saam Barati]

Created attachment 305806 [details]
WIP

might be done.

[Saam Barati]

Created attachment 305807 [details]
patch

[Saam Barati]

Created attachment 305808 [details]
patch

[Build Bot]

Attachment 305808 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jsc.cpp:79:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[JF Bastien]

Comment on attachment 305808 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305808&action=review

Looks good.

> Source/JavaScriptCore/ChangeLog:3
> +        WebAssembly: pass JSWebAssemblyInstanace to vmEntryToWasm when not using fast TLS

Typo "instance"

> Source/JavaScriptCore/wasm/WasmContext.h:39
> +using Context = JSWebAssemblyInstance;

FIXME to make this a class so we don't keep explaining to each other why it's like this for now.

[Mark Lam]

Comment on attachment 305808 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305808&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +        WebAssembly: pass JSWebAssemblyInstanace to vmEntryToWasm when not using fast TLS

typo: /JSWebAssemblyInstanace/JSWebAssemblyInstance/

[Saam Barati]

Created attachment 305811 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 305811 [details]
patch for landing

Clearing flags on attachment: 305811

Committed r214602: <http://trac.webkit.org/changeset/214602>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.