Bug 170180

Summary:

REGRESSION (r214386): [ios-simulator] LayoutTest media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html is failing

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for landing	none

Description Ryan Haddad 2017-03-28 09:21:06 PDT

LayoutTest media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html is failing

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r214474%20(227)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-scale-factor-audio.html

--- /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-scale-factor-audio-actual.txt
@@ -6,7 +6,7 @@
 PASS shadowRoot.querySelector('.media-controls').style.width is "800px"
 PASS shadowRoot.querySelector('.media-controls').style.height is "100px"
 PASS shadowRoot.querySelector('.media-controls').style.zoom is "0.5"
-PASS shadowRoot.querySelector('.media-controls').style.top is "-12.5px"
+FAIL shadowRoot.querySelector('.media-controls').style.top should be -12.5px. Was -25px.
 
 PASS successfullyParsed is true

Comment 1 Ryan Haddad 2017-03-28 09:21:43 PDT

This may have regressed with https://trac.webkit.org/changeset/214386/webkit

Comment 2 Antoine Quint 2017-03-28 09:24:38 PDT

I'll take a look at this later today.

Comment 3 Ryan Haddad 2017-03-28 09:30:35 PDT

(In reply to Antoine Quint from comment #2)
> I'll take a look at this later today.

Thanks! Marked test as failing in https://trac.webkit.org/changeset/214478/webkit.

Comment 4 Antoine Quint 2017-03-28 09:35:16 PDT

https://trac.webkit.org/changeset/214282/webkit seems more likely

Comment 5 Antoine Quint 2017-03-28 09:54:59 PDT

Created attachment 305600 [details]
Patch for landing

Comment 6 WebKit Commit Bot 2017-03-28 10:36:53 PDT

Comment on attachment 305600 [details]
Patch for landing

Clearing flags on attachment: 305600

Committed r214480: <http://trac.webkit.org/changeset/214480>

Comment 7 WebKit Commit Bot 2017-03-28 10:36:56 PDT

All reviewed patches have been landed.  Closing bug.