Bug 170171

Summary:

REGRESSION: Double-clicking the captions button while the captions popover is open prevents the popover from being opened again

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Antoine Quint 2017-03-28 02:12:57 PDT

* STEPS TO REPRODUCE
1. Launch Safari
2. Navigate to a video with captions
3. Click the captions button to open the captions popover
4. Double-click the captions button

* EXPECTED RESULTS
- Captions popover should close on the first click and open on the second click

* ACTUAL RESUTLS
- Captions popover closes on the first click, but does not open on the second click
- Captions button is left in active state as though the popover is open
- Clicking the captions button after this does not show the captions popover

Comment 1 Antoine Quint 2017-03-28 02:13:18 PDT

<rdar://problem/31095500>

Comment 2 Antoine Quint 2017-03-28 02:16:55 PDT

Created attachment 305576 [details]
Patch

Comment 3 WebKit Commit Bot 2017-03-28 03:42:42 PDT

Comment on attachment 305576 [details]
Patch

Clearing flags on attachment: 305576

Committed r214471: <http://trac.webkit.org/changeset/214471>

Comment 4 WebKit Commit Bot 2017-03-28 03:42:46 PDT

All reviewed patches have been landed.  Closing bug.