Bug 170117
| Summary: | WebSocket: don't throw for bad ports | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ap, cdumez, youennf |
| Priority: | P2 | ||
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anne van Kesteren
Instead, let the network layer handle all security checks and fail asynchronously. No need to duplicate them.
Test: https://github.com/w3c/web-platform-tests/issues/5212.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
The code change seems simple but Firefox / Chrome and Safari all throw here.
Chris Dumez
Will re-evaluate if other browsers actually implement this. But for now, I am not inclined to change our behavior.
youenn fablet
(In reply to Chris Dumez from comment #2)
> Will re-evaluate if other browsers actually implement this. But for now, I
> am not inclined to change our behavior.
This seems to add some flexibility in where we could do the checks.
If we want to keep checks at WebCore level, this might allow making things more consistent should the network layer add additional port restrictions.
This makes sense to me.
Anne van Kesteren
This was implemented at some point. We pass the relevant tests.