Bug 170042

Summary: Make inactive web processes behave as though under memory pressure.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Web Template FrameworkAssignee: Andreas Kling <kling>
Status: REOPENED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, kling, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar, Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for relanding none

Andreas Kling
Reported 2017-03-23 19:38:27 PDT
Let's try to minimize the memory impact of inactive processes.
Attachments
Patch (2.80 KB, patch)
2017-03-23 19:40 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch for relanding (4.42 KB, patch)
2017-04-05 14:45 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2017-03-23 19:40:05 PDT
Created attachment 305259 [details] Patch
Antti Koivisto
Comment 2 2017-03-23 19:48:31 PDT
Comment on attachment 305259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305259&action=review > Source/WTF/wtf/MemoryPressureHandler.cpp:196 > +bool MemoryPressureHandler::isUnderMemoryPressure() This should be renamed (to something like isInMemorySavingMode() perhaps) since we now have many ways for this to become true that have nothing to do with memory pressure.
WebKit Commit Bot
Comment 3 2017-03-24 09:45:11 PDT
Comment on attachment 305259 [details] Patch Clearing flags on attachment: 305259 Committed r214351: <http://trac.webkit.org/changeset/214351>
WebKit Commit Bot
Comment 4 2017-03-24 09:45:16 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 5 2017-03-24 09:54:51 PDT
<rdar://problem/31038445>
Ryan Haddad
Comment 6 2017-03-24 13:45:25 PDT
Reverted r214351 for reason: This change caused API test WebKit1.DidCreateJavaScriptContextBackForwardCacheTest to fail. Committed r214370: <http://trac.webkit.org/changeset/214370>
Ryan Haddad
Comment 7 2017-03-24 13:45:34 PDT
*** Bug 170069 has been marked as a duplicate of this bug. ***
Andreas Kling
Comment 8 2017-04-05 14:45:19 PDT
Created attachment 306320 [details] Patch for relanding
WebKit Commit Bot
Comment 9 2017-04-05 15:55:28 PDT
Comment on attachment 306320 [details] Patch for relanding Clearing flags on attachment: 306320 Committed r214974: <http://trac.webkit.org/changeset/214974>
WebKit Commit Bot
Comment 10 2017-04-05 15:55:30 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 11 2017-06-06 20:47:05 PDT
Reverted r214974 for reason: Causes some tabs to start using a huge amount of CPU after 8 minutes in the background Committed r217872: <http://trac.webkit.org/changeset/217872>
Note You need to log in before you can comment on or make changes to this bug.