Summary: | Let the UI process do memory kills and replace crashes with diagnostic logging. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||
Component: | Web Template Framework | Assignee: | Andreas Kling <kling> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, kling | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Andreas Kling
2017-03-23 12:08:41 PDT
Created attachment 305211 [details]
Patch
Attachment 305211 [details] did not pass style-queue:
ERROR: Source/WebCore/page/PerformanceMonitor.cpp:51: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 305212 [details]
Patch
Comment on attachment 305212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305212&action=review r=me with comments. > Source/WebKit2/ChangeLog:13 > + Also add drive-by diagnostic logging for background CPU limit kills. thank you > Source/WebKit2/UIProcess/WebProcessProxy.cpp:1131 > +void WebProcessProxy::simulateProcessCrash(const String& reason) I think this should take in an enum rather than a logging key. Logging is internal logic and I don't like that call sites have to pass in a logging key. > Source/WebKit2/UIProcess/WebProcessProxy.h:169 > + void simulateProcessCrash(const String& reason); Could be private. Created attachment 305227 [details]
Patch for landing
Comment on attachment 305227 [details] Patch for landing Rejecting attachment 305227 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 305227, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/3397585 Comment on attachment 305227 [details] Patch for landing Clearing flags on attachment: 305227 Committed r214320: <http://trac.webkit.org/changeset/214320> All reviewed patches have been landed. Closing bug. |