| Summary: | [GTK] Various build errors when plugin support is disabled | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | ManDay <manday> | ||||||||||||||||||
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | berto, bugs-noreply, buildbot, cgarcia, commit-queue, gustavo, mcatanzaro | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
I guess you're building with -DENABLE_X11_TARGET=OFF? That disables ENABLE_NETSCAPE_PLUGIN_API and causes this failure. Here's an untested fix; let me know if it works. Created attachment 305215 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 305216 [details]
Patch
Also Carlos, is it really right for ENABLE_NETSCAPE_PLUGIN_API to depend on ENABLE_X11_TARGET? I think it's not, because you spent a lot of effort making windowless plugins work on Wayland. (In reply to Michael Catanzaro from comment #5) > Also Carlos, is it really right for ENABLE_NETSCAPE_PLUGIN_API to depend on > ENABLE_X11_TARGET? I think it's not, because you spent a lot of effort > making windowless plugins work on Wayland. Probably not. Created attachment 305277 [details]
Patch
(Please approve the new version.) I still get the following error on linkage, which I suppose is related: PluginControllerProxy.cpp:(.text+0x100): undefined reference to 'WebKit::PluginControllerProxy::platformDestroy()' Created attachment 305585 [details]
Error on linkage
Created attachment 305589 [details]
Patch
Please test it again. Created attachment 305611 [details]
Errors with newest patch
Created attachment 306515 [details]
Patch
Tested my patch with -DENABLE_X11_TARGET=OFF and it worked for me, but here's another attempt. Comment on attachment 306515 [details] Patch Clearing flags on attachment: 306515 Committed r215106: <http://trac.webkit.org/changeset/215106> All reviewed patches have been landed. Closing bug. For the record: With the newest patch it works here, too. |
Created attachment 305208 [details] stderr by make The attached errors are produced during compilation