Summary: | [JSC][DFG] Make addShouldSpeculateAnyInt more conservative to avoid regression caused by Double <-> Int52 conversions | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2017-03-23 00:42:42 PDT
Created attachment 305176 [details]
Patch
Comment on attachment 305176 [details] Patch Attachment 305176 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3393619 New failing tests: perf/object-keys.html Created attachment 305179 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 305184 [details]
Patch
Comment on attachment 305184 [details]
Patch
I'll make this speculation more a bit conservative since Double to Int52 is not so cheap.
Created attachment 305213 [details]
Patch
OK, ready. Comment on attachment 305213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305213&action=review > Source/JavaScriptCore/dfg/DFGGraph.h:313 > + return (left->shouldSpeculateAnyInt() || right->shouldSpeculateAnyInt()) I think we should see NodeFlags here. Created attachment 305220 [details]
Patch
Comment on attachment 305220 [details]
Patch
OK! Now, our addShouldSpeculateAnyInt has more solid and reasonable story.
Comment on attachment 305220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305220&action=review r=me > Source/JavaScriptCore/ChangeLog:60 > + baseline patched > + > + imaging-darkroom 201.112+-3.192 ^ 189.532+-2.883 ^ definitely 1.0611x faster > + stanford-crypto-pbkdf2 103.953+-2.325 100.926+-2.396 might be 1.0300x faster > + stanford-crypto-sha256-iterative 35.103+-1.071 ? 36.049+-1.143 ? might be 1.0270x slower > + Nice Comment on attachment 305220 [details]
Patch
Thanks!
Comment on attachment 305220 [details] Patch Clearing flags on attachment: 305220 Committed r214323: <http://trac.webkit.org/changeset/214323> All reviewed patches have been landed. Closing bug. |