Bug 169993

Summary: Share more code between ManifestGenerator and /api/triggerables
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, kling, koivisto, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup cdumez: review+

Ryosuke Niwa
Reported 2017-03-22 21:48:09 PDT
Reduce the code duplication.
Attachments
Cleanup (4.43 KB, patch)
2017-03-22 21:56 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-03-22 21:56:48 PDT
Created attachment 305165 [details] Cleanup
Chris Dumez
Comment 2 2017-03-23 13:51:35 PDT
Comment on attachment 305165 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=305165&action=review r=me > Websites/perf.webkit.org/ChangeLog:14 > + (ManifestGenerator::fetch_triggearables): Extracted as a static function. Also include the ID Typo: fetch_triggearables
Ryosuke Niwa
Comment 3 2017-03-23 13:56:39 PDT
Committed r214315: <http://trac.webkit.org/changeset/214315>
Note You need to log in before you can comment on or make changes to this bug.