| Summary: | [Modern Media Controls] Controls size lags behind media size | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, ryanhaddad, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 305110 [details]
Patch
Comment on attachment 305110 [details]
Patch
Assuming smfr said this is the right place, r=me
Comment on attachment 305110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305110&action=review > Source/WebCore/html/HTMLMediaElement.cpp:-4054 > - m_resizeTaskQueue.enqueueTask(WTFMove(task)); You don't use m_resizeTaskQueue any more, so should remove it. Comment on attachment 305110 [details] Patch Attachment 305110 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3388738 New failing tests: media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html Created attachment 305115 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 305130 [details]
Patch for landing
Comment on attachment 305130 [details] Patch for landing Clearing flags on attachment: 305130 Committed r214282: <http://trac.webkit.org/changeset/214282> All reviewed patches have been landed. Closing bug. (In reply to WebKit Commit Bot from comment #8) > Comment on attachment 305130 [details] > Patch for landing > > Clearing flags on attachment: 305130 > > Committed r214282: <http://trac.webkit.org/changeset/214282> This change appears to have caused LayoutTest media/restore-from-page-cache.html to consistently crash on Sierra Debug WK1: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r214308%20(125)/results.html |
Created attachment 305109 [details] Testcase When resizing a video element, it's very visible that the controls size lags behind the media size. The attached test case makes it very clear. The issue is that we fire the "resize" event on the shadow root on a timer to notify the JS code, and on top of that we use a requestAnimationFrame() call to update the DOM.