Bug 169934

Summary:

Prevent new navigations during document unload

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Page Loading

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, ap, beidson, buildbot, cdumez, esprehn+autocc, japhet, kangil.han, lokihardt, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch and layout test	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch and layout test	cdumez: review+

Daniel Bates

Reported 2017-03-21 16:31:23 PDT

Similar to our policy of preventing new navigations from onbeforeunload handlers we should prevent new navigations that are initiated from onunload handlers. Such navigations go against the expectation of the user.

Attachments
Patch and layout test (10.59 KB, patch) 2017-03-21 16:49 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (985.35 KB, application/zip) 2017-03-21 21:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.02 MB, application/zip) 2017-03-21 22:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.76 MB, application/zip) 2017-03-21 22:08 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (deleted) 2017-03-21 22:29 PDT, Build Bot	no flags	Details
Patch and layout test (8.56 KB, patch) 2017-03-24 10:33 PDT, Daniel Bates	cdumez: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2017-03-21 16:49:50 PDT

Created attachment 305051 [details] Patch and layout test

Build Bot

Comment 2 2017-03-21 21:53:38 PDT

Comment on attachment 305051 [details] Patch and layout test Attachment 305051 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3379602 New failing tests: fast/frames/reparent-in-unload-contentdocument.html fast/parser/xml-error-unload-iframe.html fast/frames/unload-reparent-sibling-frame.html fast/loader/unload-hyperlink-targeted.html

Build Bot

Comment 3 2017-03-21 21:53:40 PDT

Created attachment 305073 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-03-21 22:00:40 PDT

Comment on attachment 305051 [details] Patch and layout test Attachment 305051 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3379631 New failing tests: fast/frames/reparent-in-unload-contentdocument.html fast/loader/unload-hyperlink-targeted.html fast/frames/unload-reparent-sibling-frame.html fast/parser/xml-error-unload-iframe.html

Build Bot

Comment 5 2017-03-21 22:00:42 PDT

Created attachment 305074 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-03-21 22:08:25 PDT

Comment on attachment 305051 [details] Patch and layout test Attachment 305051 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3379629 New failing tests: fast/frames/reparent-in-unload-contentdocument.html fast/parser/xml-error-unload-iframe.html fast/frames/unload-reparent-sibling-frame.html fast/loader/unload-hyperlink-targeted.html

Build Bot

Comment 7 2017-03-21 22:08:27 PDT

Created attachment 305075 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-03-21 22:29:38 PDT

Comment on attachment 305051 [details] Patch and layout test Attachment 305051 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3379688 New failing tests: fast/frames/reparent-in-unload-contentdocument.html fast/parser/xml-error-unload-iframe.html fast/frames/unload-reparent-sibling-frame.html fast/loader/unload-hyperlink-targeted.html

Build Bot

Comment 9 2017-03-21 22:29:43 PDT

Created attachment 305077 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Daniel Bates

Comment 10 2017-03-24 10:33:24 PDT

Created attachment 305294 [details] Patch and layout test

Chris Dumez

Comment 11 2017-03-24 12:09:43 PDT

Comment on attachment 305294 [details] Patch and layout test r=me, nice.

Daniel Bates

Comment 12 2017-03-24 12:31:52 PDT

<rdar://problem/31247584>

Daniel Bates

Comment 13 2017-03-24 12:34:20 PDT

Committed r214365: <http://trac.webkit.org/changeset/214365>

Lucas Forschler

Comment 14 2019-02-06 09:18:53 PST

Mass move bugs into the DOM component.

Brent Fulgham

Comment 15 2022-02-11 14:41:25 PST

*** Bug 169121 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.