Bug 169906 – Resource Load Statistics: Fix partitioning bug for client-side cookie access

• Component: WebKit2
• Status: RESOLVED FIXED

[John Wilander]

The partitioning list should be checked for client-side cookie access.

[Radar WebKit Bug Importer]

<rdar://problem/31164456>

[John Wilander]

Created attachment 304988 [details]
Patch

[John Wilander]

Created attachment 304989 [details]
Patch

[John Wilander]

I realized I can simplify this and make it more efficient. In essence, fold these two code paths into one which would have avoided the bug from the beginning. New patch coming up.

[John Wilander]

Created attachment 304990 [details]
Patch

[Brent Fulgham]

Comment on attachment 304990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304990&action=review

Looks good -- please have Alex give final review.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:120
> +    auto domain = url.host();

Delete this line.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:122
> +    domain = topPrivatelyControlledDomain(domain);

Make this "auto domain = top...."

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:124
> +        domain = url.host();

#else
    auto domain = url.host();

[Alex Christensen]

Comment on attachment 304990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304990&action=review

> Source/WebKit2/ChangeLog:17
> [phone]  John Wilander  <[e-mail]>

This has two ChangeLog entries.

[John Wilander]

Created attachment 305050 [details]
Patch

[John Wilander]

Thanks for the review comments, Brent and Alex! I'll just let the patch go through an EWS build and then put it on the commit queue.

[John Wilander]

Comment on attachment 305050 [details]
Patch

Adding to commit queue. Don't know what's up with EWS but the analysis seems to have been dropped.

[WebKit Commit Bot]

Comment on attachment 305050 [details]
Patch

Rejecting attachment 305050 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 305050, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a9396d15124a3b355073e9b2cac25b706b5
r214262 = dd961cd4754677276d05cbdf98f7c6a25cc89142
r214263 = 86e77173f6c6125d25b9b58efb5a2f507881bd43
r214264 = 4011743cf6bfcc8528801fa32ec45fc9d20e3f64
r214265 = 00cf9f48b91a26af60292ed1cd25efb2864f3664
r214266 = 756915c25fcb57ddb4b94b8c936ebb0dface6d93
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/3388543

[John Wilander]

Created attachment 305113 [details]
Patch

[John Wilander]

Let's see if EWS is in a better mood today.

[WebKit Commit Bot]

Comment on attachment 305113 [details]
Patch

Clearing flags on attachment: 305113

Committed r214270: <http://trac.webkit.org/changeset/214270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.