Summary: | Web Inspector: Editing local storage keys/values starts with truncated strings | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, inspector-bugzilla-changes, mattbaker | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | All | ||||||||||||||||||
OS: | All | ||||||||||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2017-03-20 16:15:14 PDT
Created attachment 304963 [details]
Patch
Created attachment 304965 [details]
[Animated GIF] With patch applied
Nice, I noticed this a while back. Comment on attachment 304963 [details]
Patch
r-, for some reason `text-overflow: ellipsis` isn't restored after cancel/commit.
(In reply to comment #4) > Comment on attachment 304963 [details] > Patch > > r-, for some reason `text-overflow: ellipsis` isn't restored after > cancel/commit. After canceling <td class="value-column"> <div class="cell-content">foo</div> </td> gets replaced with <td class="value-column">foo</td> 🤦♂️ Created attachment 305062 [details]
Patch
I've tried making <div class=cell-content> editable instead of <td>, but it appeared to be difficult to style to make it look the way <td class=editing> looks now.
I ended up re-creating <div class=cell-content> after every edit.
Created attachment 305138 [details]
Patch
As per an offline discussion with Brian, there should be only one code path for creating <div class=cell-content>.
Comment on attachment 305138 [details] Patch Attachment 305138 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3390911 New failing tests: media/video-main-content-autoplay.html Created attachment 305149 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 305203 [details]
Patch
Unrelated flaky test. Re-uploading the patch.
Comment on attachment 305203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305203&action=review r=me > Source/WebInspectorUI/ChangeLog:13 > + since it may get removed while editing. You should mention that div.cell-content is removed because the <td> itself is contenteditable (using the fancy -webkit-user-modify:read-write-plaintext-only), not the inner div.cell-content. Created attachment 305204 [details]
Patch
Comment on attachment 305204 [details] Patch Clearing flags on attachment: 305204 Committed r214308: <http://trac.webkit.org/changeset/214308> All reviewed patches have been landed. Closing bug. |