Bug 169870

Summary:

[MediaStream] Respect constraints passed to getUserMedia

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

ASSIGNED

Severity:

Normal

CC:

commit-queue, jer.noble, jonlee, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	none
Patch for landing.	none

Eric Carlson

Reported 2017-03-19 18:44:01 PDT

The fitness score calculated for constraints passed to getUserMedia is not used when selecting between multiple devices.

Attachments
Proposed patch. (37.45 KB, patch) 2017-03-19 19:03 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing. (38.12 KB, patch) 2017-03-20 10:12 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-03-19 18:45:10 PDT

<rdar://problem/31138936>

Eric Carlson

Comment 2 2017-03-19 19:03:12 PDT

Created attachment 304910 [details] Proposed patch.

Jer Noble

Comment 3 2017-03-20 09:56:40 PDT

Comment on attachment 304910 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=304910&action=review > LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-expected.txt:31 > +FAIL deviceIds.indexOf(captureDevice.deviceId) should not be -1. Is this an expected failure? > LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-expected.txt:38 > +FAIL deviceIds.indexOf(captureDevice.deviceId) should not be -1. Ditto > LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-expected.txt:64 > +FAIL deviceIds.indexOf(captureDevice.deviceId) should not be -1. Ditto > LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-expected.txt:71 > +FAIL deviceIds.indexOf(captureDevice.deviceId) should not be -1. Ditto > LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-expected.txt:97 > +FAIL deviceIds.indexOf(captureDevice.deviceId) should not be -1. Ditto > LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-expected.txt:104 > +FAIL deviceIds.indexOf(captureDevice.deviceId) should not be -1. Ditto. If so, we should come up with a way of reporting it as a "PASS, failed expectedly."

Eric Carlson

Comment 4 2017-03-20 10:03:13 PDT

Comment on attachment 304910 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=304910&action=review >> LayoutTests/fast/mediastream/MediaDevices-enumerateDevices-expected.txt:104 >> +FAIL deviceIds.indexOf(captureDevice.deviceId) should not be -1. > > Ditto. > > If so, we should come up with a way of reporting it as a "PASS, failed expectedly." Oops, I need to update the test and results now that there are four mock devices. Good catch!

Eric Carlson

Comment 5 2017-03-20 10:12:38 PDT

Created attachment 304929 [details] Patch for landing.

WebKit Commit Bot

Comment 6 2017-03-20 10:55:24 PDT

Comment on attachment 304929 [details] Patch for landing. Clearing flags on attachment: 304929 Committed r214178: <http://trac.webkit.org/changeset/214178>

Note You need to log in before you can comment on or make changes to this bug.