Bug 169818

Summary: Make SocketStreamHandle virtual functions asynchronous
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch aestes: review+

Alex Christensen
Reported 2017-03-17 11:00:27 PDT
Make SocketStreamHandle virtual functions asynchronous
Attachments
Patch (20.81 KB, patch)
2017-03-17 11:08 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (20.77 KB, patch)
2017-03-17 12:11 PDT, Alex Christensen 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-03-17 11:08:28 PDT
Created attachment 304799 [details] Patch
Alex Christensen
Comment 2 2017-03-17 12:11:36 PDT
Created attachment 304807 [details] Patch
Andy Estes
Comment 3 2017-03-17 13:15:48 PDT
Comment on attachment 304807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304807&action=review > Source/WebCore/platform/network/SocketStreamHandle.h:55 > + virtual void platformSend(const char* data, size_t length, Function<void(bool)>) = 0; Why not make the Function an rvalue reference?
Brady Eidson
Comment 4 2017-03-17 13:18:44 PDT
(In reply to comment #3) > Comment on attachment 304807 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304807&action=review > > > Source/WebCore/platform/network/SocketStreamHandle.h:55 > > + virtual void platformSend(const char* data, size_t length, Function<void(bool)>) = 0; > > Why not make the Function an rvalue reference? In fact, for general use you'd *have too*, because Functions are non copyable.
Alex Christensen
Comment 5 2017-03-17 13:31:23 PDT
I don't have to, but I did. http://trac.webkit.org/r214114
Note You need to log in before you can comment on or make changes to this bug.