Bug 169807

Summary: RealtimeIncomingAudioSource is not stopping properly
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, eric.carlson, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Patch none

Description youenn fablet 2017-03-16 21:09:37 PDT
There is a typo in RealtimeIncomingAudioSource::stopProducingData which prevents it from stopping.
Comment 1 youenn fablet 2017-03-16 21:11:31 PDT
Created attachment 304749 [details]
Patch
Comment 2 youenn fablet 2017-03-16 21:14:43 PDT
Created attachment 304750 [details]
Patch
Comment 3 youenn fablet 2017-03-16 21:16:18 PDT
Test is not exercising the potential crash path, but should be close to it so this is a worthwhile addition anyway.
Comment 4 Build Bot 2017-03-16 22:28:13 PDT
Comment on attachment 304750 [details]
Patch

Attachment 304750 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3346552

New failing tests:
webrtc/libwebrtc/release-after-getting-track.html
Comment 5 Build Bot 2017-03-16 22:28:16 PDT
Created attachment 304756 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 youenn fablet 2017-03-16 22:36:37 PDT
Created attachment 304757 [details]
Patch
Comment 7 WebKit Commit Bot 2017-03-17 10:16:54 PDT
Comment on attachment 304757 [details]
Patch

Clearing flags on attachment: 304757

Committed r214108: <http://trac.webkit.org/changeset/214108>
Comment 8 WebKit Commit Bot 2017-03-17 10:17:00 PDT
All reviewed patches have been landed.  Closing bug.