Bug 169776 – Update the WKHTTPCookieStore API to be simpler and add observers

• Component: WebKit2
• Status: RESOLVED FIXED

[Brady Eidson]

Update the WKHTTPCookieStore API to be simpler and add observers

[Radar WebKit Bug Importer]

<rdar://problem/31096000>

[Brady Eidson]

Created attachment 304680 [details]
Patch

[WebKit Commit Bot]

Attachment 304680 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStore.mm:58:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:94:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:99:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:96:  Missing space before {  [whitespace/braces] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:103:  Missing space before {  [whitespace/braces] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:139:  Missing space before {  [whitespace/braces] [5]
Total errors found: 7 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 304680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304680&action=review

Fix GTK.
You might need to use _saveCookies sometimes, like before we read all cookies?

> Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStore.h:67
> + @discussion Your observer is not retained by the receiver. It is your responsibility

Who is the intended antecedent of "your"?

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:126
> +    HashSet<RefPtr<WebProcessPool>> processPools(size_t count = std::numeric_limits<size_t>::max(), bool ensureOneExists = true) const;

One always exists.  It is the integer between zero and two.
And we don't need a process pool to exist to access the default cookie storage.

[Brady Eidson]

(In reply to comment #4)
> Comment on attachment 304680 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304680&action=review
> 
> Fix GTK.
> You might need to use _saveCookies sometimes, like before we read all
> cookies?
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStore.h:67
> > + @discussion Your observer is not retained by the receiver. It is your responsibility
> 
> Who is the intended antecedent of "your"?
> 
> > Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:126
> > +    HashSet<RefPtr<WebProcessPool>> processPools(size_t count = std::numeric_limits<size_t>::max(), bool ensureOneExists = true) const;
> 
> One always exists.  It is the integer between zero and two.
> And we don't need a process pool to exist to access the default cookie
> storage.

I'll come up with a better name for the bool, but the concern is not for needing a process pool for default cookie storage.

[Brady Eidson]

Created attachment 304706 [details]
Patch

[WebKit Commit Bot]

Attachment 304706 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:228:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStore.mm:58:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:94:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:99:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:96:  Missing space before {  [whitespace/braces] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:103:  Missing space before {  [whitespace/braces] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:139:  Missing space before {  [whitespace/braces] [5]
Total errors found: 9 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 304706 [details]
Patch

Clearing flags on attachment: 304706

Committed r214078: <http://trac.webkit.org/changeset/214078>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.