Bug 169765

Summary:

Web Inspector: RTL: minor layout issues in Breakpoint Editor popover

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, hi, inspector-bugzilla-changes, mattbaker

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[RTL] screenshot	none
Patch	none
[image] After Patch is applied	none
Patch	none
[Image] After Patch is applied	none

Blaze Burg

Reported 2017-03-16 10:34:28 PDT

Created attachment 304652 [details] [RTL] screenshot - There is no padding between some inputs and labels - The help text for log statements has flipped braces. This is a Webcore bug we may need to work around. - text input fields for log messages, etc should be forced LTR.

Attachments
[RTL] screenshot (133.94 KB, image/png) 2017-03-16 10:34 PDT, Blaze Burg	no flags	Details
Patch (6.78 KB, patch) 2017-03-16 12:37 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[image] After Patch is applied (104.43 KB, image/png) 2017-03-16 12:37 PDT, Devin Rousso	no flags	Details
Patch (8.17 KB, patch) 2017-03-18 18:12 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (96.96 KB, image/png) 2017-03-18 18:12 PDT, Devin Rousso	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-03-16 12:37:17 PDT

Created attachment 304675 [details] Patch

Devin Rousso

Comment 2 2017-03-16 12:37:35 PDT

Created attachment 304676 [details] [image] After Patch is applied

Matt Baker

Comment 3 2017-03-16 13:12:26 PDT

Is it possible to align the Condition placeholder as well? The rest looks good (except for the issue with the expression hint, but that's a text rendering bug AFAIK).

Devin Rousso

Comment 4 2017-03-16 13:22:36 PDT

(In reply to comment #3) > Is it possible to align the Condition placeholder as well? The rest looks > good (except for the issue with the expression hint, but that's a text > rendering bug AFAIK). I think we set every CodeMirror instance to RTL due to some issues with they way it renders scrollbars.

Blaze Burg

Comment 5 2017-03-18 16:55:07 PDT

(In reply to comment #3) > Is it possible to align the Condition placeholder as well? The rest looks > good (except for the issue with the expression hint, but that's a text > rendering bug AFAIK). For the latter issue, this can be fixed by setting dir=ltr and using text-align:right for body[dir=rtl]. The string is localized, but will still render wrong because curly braces get swapped for some reason.

Blaze Burg

Comment 6 2017-03-18 16:56:31 PDT

Comment on attachment 304675 [details] Patch r- because we need to force LTR for the action fields (log message ,evaluate script, etc). As is, the hint text is wrong and the field doesn't match the condition editor which is codemirror-backed.

Devin Rousso

Comment 7 2017-03-18 18:12:00 PDT

Created attachment 304890 [details] Patch

Devin Rousso

Comment 8 2017-03-18 18:12:26 PDT

Created attachment 304891 [details] [Image] After Patch is applied

Blaze Burg

Comment 9 2017-03-20 19:26:38 PDT

Comment on attachment 304890 [details] Patch r=me

WebKit Commit Bot

Comment 10 2017-03-20 20:27:51 PDT

Comment on attachment 304890 [details] Patch Clearing flags on attachment: 304890 Committed r214210: <http://trac.webkit.org/changeset/214210>

WebKit Commit Bot

Comment 11 2017-03-20 20:27:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.