| Summary: | Web Inspector: RTL: minor layout issues in Breakpoint Editor popover | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, mattbaker | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 304675 [details]
Patch
Created attachment 304676 [details]
[image] After Patch is applied
Is it possible to align the Condition placeholder as well? The rest looks good (except for the issue with the expression hint, but that's a text rendering bug AFAIK). (In reply to comment #3) > Is it possible to align the Condition placeholder as well? The rest looks > good (except for the issue with the expression hint, but that's a text > rendering bug AFAIK). I think we set every CodeMirror instance to RTL due to some issues with they way it renders scrollbars. (In reply to comment #3) > Is it possible to align the Condition placeholder as well? The rest looks > good (except for the issue with the expression hint, but that's a text > rendering bug AFAIK). For the latter issue, this can be fixed by setting dir=ltr and using text-align:right for body[dir=rtl]. The string is localized, but will still render wrong because curly braces get swapped for some reason. Comment on attachment 304675 [details]
Patch
r- because we need to force LTR for the action fields (log message ,evaluate script, etc). As is, the hint text is wrong and the field doesn't match the condition editor which is codemirror-backed.
Created attachment 304890 [details]
Patch
Created attachment 304891 [details]
[Image] After Patch is applied
Comment on attachment 304890 [details]
Patch
r=me
Comment on attachment 304890 [details] Patch Clearing flags on attachment: 304890 Committed r214210: <http://trac.webkit.org/changeset/214210> All reviewed patches have been landed. Closing bug. |
Created attachment 304652 [details] [RTL] screenshot - There is no padding between some inputs and labels - The help text for log statements has flipped braces. This is a Webcore bug we may need to work around. - text input fields for log messages, etc should be forced LTR.