Bug 169758

Summary: [mac-wk2 debug] LayoutTest webrtc/video-mute.html is timing out
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Comment 1 Ryan Haddad 2017-03-16 09:16:36 PDT
This test was added with https://trac.webkit.org/changeset/213983
Comment 2 youenn fablet 2017-03-16 12:05:19 PDT
Created attachment 304666 [details]
Patch
Comment 3 Eric Carlson 2017-03-16 12:10:47 PDT
Comment on attachment 304666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304666&action=review

> Source/WebKit2/ChangeLog:8
> +        Test is timing out due to the UIProcess requesting to disable/enable ICE candidate filtering on a page whose preference is set to not enabling ICE candidate filtering.

Nit: please wrap this line.
Comment 4 youenn fablet 2017-03-16 12:15:10 PDT
Created attachment 304667 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-03-16 12:16:30 PDT
Comment on attachment 304667 [details]
Patch for landing

Rejecting attachment 304667 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 304667, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
IProcess/UserMediaProcessManager.cpp
patching file Source/WebKit2/WebProcess/WebPage/WebPage.cpp
patching file Source/WebKit2/WebProcess/WebPage/WebPage.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/TestExpectations
Hunk #1 FAILED at 711.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3340036
Comment 6 youenn fablet 2017-03-16 13:25:39 PDT
Created attachment 304683 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-03-16 13:42:57 PDT
Comment on attachment 304683 [details]
Patch for landing

Clearing flags on attachment: 304683

Committed r214063: <http://trac.webkit.org/changeset/214063>
Comment 8 WebKit Commit Bot 2017-03-16 13:43:01 PDT
All reviewed patches have been landed.  Closing bug.