Bug 169747

Summary: _blank / _self / _parent / _top browsing context names should be case-insensitive
Product: WebKit Reporter: Lyza Gardner <lyza>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, dbates, japhet, phistuck, rniwa, sam, zcorpan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=169748
https://bugs.webkit.org/show_bug.cgi?id=170128
Attachments:
Description Flags
Patch none

Lyza Gardner
Reported 2017-03-16 06:15:18 PDT
Per section 7.1.5 Named Browsing Contexts[1] of the WHATWG HTML specification: > A valid browsing context name or keyword is any string that is either a valid browsing context name or that is an ASCII case-insensitive match for one of: _blank, _self, _parent, or _top. However, the behavior observed is that case-mixed variants of `_blank` are treated as non-keyword browsing context names. To reproduce, e.g.: 1. `window.open` into `_bLAnk` 2. `window.open` into `_bLAnk` Expected result: Browser should create two new browsing contexts, treating `_bLAnk` as a case-insensitive match for the keyword `_blank`. Actual result: Browser only creates one new browsing context. The second invocation of `window.open` reuses the `_bLAnk` browsing context created by the first invocation. Relevant web-platform-tests: https://github.com/w3c/web-platform-tests/pull/5145 [1] https://html.spec.whatwg.org/#browsing-context-names
Attachments
Patch (46.07 KB, patch)
2017-04-04 20:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
PhistucK
Comment 1 2017-03-20 03:37:18 PDT
Filed an HTML issue, so this might not be a bug - https://github.com/whatwg/html/issues/2443
Simon Pieters (:zcorpan)
Comment 2 2017-03-27 00:24:29 PDT
Concluded in https://github.com/whatwg/html/issues/2443#issuecomment-289043039 that case-insensitive is better.
Chris Dumez
Comment 3 2017-04-04 20:11:02 PDT
Created attachment 306240 [details] Patch
Chris Dumez
Comment 4 2017-04-04 20:13:33 PDT
*** Bug 169748 has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 5 2017-04-04 20:13:38 PDT
*** Bug 170128 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 6 2017-04-05 06:36:50 PDT
Comment on attachment 306240 [details] Patch Clearing flags on attachment: 306240 Committed r214944: <http://trac.webkit.org/changeset/214944>
WebKit Commit Bot
Comment 7 2017-04-05 06:36:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.