Bug 16971

Summary: Canvas underpainting bug
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2 Keywords: NeedsReduction
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://jsmsxdemo.googlepages.com/jsmsx.html
Attachments:
Description Flags
patch with assertion to check if passed-in rect is correct none

Oliver Hunt
Reported 2008-01-22 01:53:54 PST
There's a canvas underpainting bug almost certainly introduced by the "improved" canvas repaint logic i landed not too long ago. (r29448) /me expects an "i told you so" from darin :(
Attachments
patch with assertion to check if passed-in rect is correct (15.42 KB, patch)
2008-01-22 18:05 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-01-22 18:05:02 PST
Created attachment 18614 [details] patch with assertion to check if passed-in rect is correct
Darin Adler
Comment 2 2008-01-22 18:06:10 PST
To make this bug go away, I turned off the smart canvas incremental painting that Oliver added. So this bug won't happen until we turn the incremental painting back on. I attached a patch in progress that adds a debugging check to catch canvas operations that pass an incorrect dirty rect. Not ready to land yet.
Note You need to log in before you can comment on or make changes to this bug.