Summary: | [WebRTC] SDP sess-id in the "o=" line should be a value between 0 and LLONG_MAX. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | WebCore Misc. | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alex, bugs-noreply, darin, fpizlo, mcatanzaro, saam, youennf, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2017-03-15 09:36:24 PDT
Created attachment 304523 [details]
Patch
This seems like something that should be possible to test for, right? Created attachment 304570 [details]
Patch
Add a check for the sess-id value on the tests
Comment on attachment 304570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304570&action=review Good catch! LGTM > LayoutTests/fast/mediastream/resources/sdp-utils.js:32 > + if (sessid > 0 && sessid <= 9223372036854775807) Can we comment what that number is or add it to a constant somewhere that explains? Committed r214037: <http://trac.webkit.org/changeset/214037> |