Bug 169658

Summary: run-webkit-tests is always creating mock libwebrtc tracks
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2017-03-14 21:39:58 PDT
This breaks webrtc/video.html
Comment 1 youenn fablet 2017-03-14 21:44:52 PDT
Created attachment 304471 [details]
Patch
Comment 2 Alex Christensen 2017-03-14 23:17:45 PDT
Comment on attachment 304471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304471&action=review

> LayoutTests/webrtc/peer-connection-audio-mute-expected.txt:2
> +FAIL Muting and unmuting an audio track assert_true: heard hum expected true got false

I assume this will be fixed in a coming patch.
Comment 3 youenn fablet 2017-03-15 09:08:17 PDT
(In reply to comment #2)
> Comment on attachment 304471 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304471&action=review
> 
> > LayoutTests/webrtc/peer-connection-audio-mute-expected.txt:2
> > +FAIL Muting and unmuting an audio track assert_true: heard hum expected true got false
> 
> I assume this will be fixed in a coming patch.

I need to investigate why the web audio is no longer working.
It regressed before the tests were active in bots.
I wil try to fix it.
Comment 4 WebKit Commit Bot 2017-03-15 09:38:13 PDT
Comment on attachment 304471 [details]
Patch

Clearing flags on attachment: 304471

Committed r213983: <http://trac.webkit.org/changeset/213983>
Comment 5 WebKit Commit Bot 2017-03-15 09:38:16 PDT
All reviewed patches have been landed.  Closing bug.