Bug 169658

Summary:

run-webkit-tests is always creating mock libwebrtc tracks

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

youenn fablet

Reported 2017-03-14 21:39:58 PDT

This breaks webrtc/video.html

Attachments
Patch (21.90 KB, patch) 2017-03-14 21:44 PDT, youenn fablet	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-03-14 21:44:52 PDT

Created attachment 304471 [details] Patch

Alex Christensen

Comment 2 2017-03-14 23:17:45 PDT

Comment on attachment 304471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304471&action=review > LayoutTests/webrtc/peer-connection-audio-mute-expected.txt:2 > +FAIL Muting and unmuting an audio track assert_true: heard hum expected true got false I assume this will be fixed in a coming patch.

youenn fablet

Comment 3 2017-03-15 09:08:17 PDT

(In reply to comment #2) > Comment on attachment 304471 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304471&action=review > > > LayoutTests/webrtc/peer-connection-audio-mute-expected.txt:2 > > +FAIL Muting and unmuting an audio track assert_true: heard hum expected true got false > > I assume this will be fixed in a coming patch. I need to investigate why the web audio is no longer working. It regressed before the tests were active in bots. I wil try to fix it.

WebKit Commit Bot

Comment 4 2017-03-15 09:38:13 PDT

Comment on attachment 304471 [details] Patch Clearing flags on attachment: 304471 Committed r213983: <http://trac.webkit.org/changeset/213983>

WebKit Commit Bot

Comment 5 2017-03-15 09:38:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.