Bug 169630

Summary:

Rename WKHTTPCookieStorage to WKHTTPCookieStore

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Brady Eidson

Reported 2017-03-14 14:38:35 PDT

Rename WKHTTPCookieStorage to WKHTTPCookieStore This better reflects its relation to WKWebsiteDataStore

Attachments
Patch (71.99 KB, patch) 2017-03-14 14:48 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (68.41 KB, patch) 2017-03-14 14:50 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (68.40 KB, patch) 2017-03-14 14:54 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-03-14 14:48:33 PDT

Created attachment 304426 [details] Patch

Brady Eidson

Comment 2 2017-03-14 14:49:05 PDT

Whoops, I have two patches in here, hang on.

Brady Eidson

Comment 3 2017-03-14 14:50:02 PDT

Created attachment 304428 [details] Patch

WebKit Commit Bot

Comment 4 2017-03-14 14:52:48 PDT

Attachment 304428 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:76: Missing space before { [whitespace/braces] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:61: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 18 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 5 2017-03-14 14:54:43 PDT

Created attachment 304431 [details] Patch

Brady Eidson

Comment 6 2017-03-14 14:55:08 PDT

Comment on attachment 304431 [details] Patch Tim reviewed on IRC, could not access bugzilla.

WebKit Commit Bot

Comment 7 2017-03-14 14:56:44 PDT

Attachment 304431 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:76: Missing space before { [whitespace/braces] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.cpp:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:54: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIHTTPCookieStore.h:61: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 18 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 8 2017-03-14 15:36:56 PDT

Comment on attachment 304431 [details] Patch Clearing flags on attachment: 304431 Committed r213947: <http://trac.webkit.org/changeset/213947>

WebKit Commit Bot

Comment 9 2017-03-14 15:37:01 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.