|Summary:||Fix uninitialized public members in Webkit2/UIProcess/API/gtk|
|Product:||WebKit||Reporter:||Tomas Popela <tpopela>|
|Component:||WebKitGTK||Assignee:||Tomas Popela <tpopela>|
|Severity:||Normal||CC:||berto, bugs-noreply, cdumez, cgarcia, clopez, commit-queue, gns, mcatanzaro|
|Version:||WebKit Nightly Build|
|Bug Depends on:|
Description Tomas Popela 2017-03-14 07:16:27 PDT
Found by Coverity scan.
Comment 2 WebKit Commit Bot 2017-03-14 07:20:15 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2017-03-14 08:11:52 PDT
Comment on attachment 304376 [details] Patch I was going to say "Please fix the ChangeLog" again but now I realize that you've been including all of the changes from all previous patch. Definitely need to look at this. :P
Comment 4 Tomas Popela 2017-03-15 00:16:19 PDT
Created attachment 304483 [details] Patch Correct the patch (after I previously had some problems with webkit-patch).
Comment 5 Tomas Popela 2017-03-15 07:01:05 PDT
Created attachment 304497 [details] Patch Add the missing space.
Comment 6 Tomas Popela 2017-03-16 01:40:36 PDT
Comment on attachment 304497 [details] Patch Clearing flags on attachment: 304497 Committed r214034: <http://trac.webkit.org/changeset/214034>
Comment 7 Tomas Popela 2017-03-16 01:40:46 PDT
All reviewed patches have been landed. Closing bug.
Comment 8 Carlos Garcia Campos 2017-04-03 02:55:54 PDT
Initializing private structs to 0/nullptr is just noise, glib already fills them with 0 on allocation.