| Summary: | Fix uninitialized public members in Webkit2/UIProcess/API/gtk | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tomas Popela <tpopela> | ||||||||
| Component: | WebKitGTK | Assignee: | Tomas Popela <tpopela> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | berto, bugs-noreply, cdumez, cgarcia, clopez, commit-queue, gustavo, mcatanzaro | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 104114 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tomas Popela
2017-03-14 07:16:27 PDT
Created attachment 304376 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 304376 [details]
Patch
I was going to say "Please fix the ChangeLog" again but now I realize that you've been including all of the changes from all previous patch. Definitely need to look at this. :P
Created attachment 304483 [details]
Patch
Correct the patch (after I previously had some problems with webkit-patch).
Created attachment 304497 [details]
Patch
Add the missing space.
Comment on attachment 304497 [details] Patch Clearing flags on attachment: 304497 Committed r214034: <http://trac.webkit.org/changeset/214034> All reviewed patches have been landed. Closing bug. Initializing private structs to 0/nullptr is just noise, glib already fills them with 0 on allocation. (In reply to Carlos Garcia Campos from comment #8) > Initializing private structs to 0/nullptr is just noise, glib already fills > them with 0 on allocation. Yup, please don't do this! |