Bug 169553

Summary:

[Modern Media Controls] Volume icon doesn't turn to mute when the knob is set to 0

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=169568

Attachments:

Description	Flags
Patch	none

Antoine Quint

Reported 2017-03-13 06:58:34 PDT

Drag the volume knob to 0. It should change the volume icon to the mute icon. The previous controls had a bug where after you toggle the speaker icon then it would toggle between muted and the last value, 0, so the knob never moved. In this case, I think we should remember the volume value on mouse down prior to the drag of the knob to 0. So you can: 1) Have the knob at some value (say .6) 2) Drag the knob to 0. The speaker icon turns to mute. 3) Click on the speaker icon to unmute. It goes back up to .6.

Attachments
Patch (13.67 KB, patch) 2017-03-13 08:42 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2017-03-13 06:58:51 PDT

<rdar://problem/30754543>

Antoine Quint

Comment 2 2017-03-13 08:42:47 PDT

Created attachment 304258 [details] Patch

WebKit Commit Bot

Comment 3 2017-03-13 09:39:12 PDT

Comment on attachment 304258 [details] Patch Clearing flags on attachment: 304258 Committed r213848: <http://trac.webkit.org/changeset/213848>

WebKit Commit Bot

Comment 4 2017-03-13 09:39:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.