Bug 169552
| Summary: | XMLHttpRequest: upload listener flag not implemented correctly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, cdumez, rniwa, youennf |
| Priority: | P2 | ||
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anne van Kesteren
In particular, it seems to be bypassed for same-origin requests, which is unlikely to work well, as same-origin can be redirected to cross-origin.
https://github.com/w3c/web-platform-tests/pull/5122
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
> same-origin can be redirected to cross-origin
Have we added support for such redirection already? If so, this bug sounds pretty bad.
youenn fablet
(In reply to comment #1)
> > same-origin can be redirected to cross-origin
>
> Have we added support for such redirection already? If so, this bug sounds
> pretty bad.
Indeed, we need to fix that!
Ahmad Saleem
Safari Technology Preview 151 pass all tests, which WPT Pull Request was trying to modifying:
https://wpt.fyi/results/xhr?label=master&label=experimental&aligned&view=subtest&q=event-upload-progress
Is anything else needed? Thanks!
Alexey Proskuryakov
Passing these tests is a pretty strong indication that this now works. Maybe fixed in 211702@main?
We have a lot of flakiness, but it's tracked in other bugs already:
LayoutTests/platform/mac-wk1/TestExpectations:1480:webkit.org/b/223944 [ BigSur Debug ] imported/w3c/web-platform-tests/xhr/event-upload-progress.any.html [ Pass Failure ]
LayoutTests/platform/mac/TestExpectations:1969:webkit.org/b/223271 [ Debug ] imported/w3c/web-platform-tests/xhr/event-upload-progress.any.worker.html [ Pass Failure ]
LayoutTests/platform/mac/TestExpectations:2098:webkit.org/b/222385 imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.worker.html [ Pass Failure ]
LayoutTests/platform/mac/TestExpectations:2100:webkit.org/b/223804 imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.html [ Pass Failure ]