Bug 169481 – LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r213715%20(2555)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Flibwebrtc%2FdescriptionGetters.html

--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/webrtc/libwebrtc/descriptionGetters-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/webrtc/libwebrtc/descriptionGetters-actual.txt
@@ -1,3 +1,3 @@
 
-PASS description getters when changing description from video to video & data channel 
+FAIL description getters when changing description from video to video & data channel assert_equals: expected "v=0\r\no=- 6964394637269189587 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE video\r\na=msid-semantic: WMS dc1214d7-b183-4ef9-a8d2-416278b274ac\r\nm=video 9 UDP/TLS/RTP/SAVPF 96 98 99 97 100\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:H31i\r\na=ice-pwd:cBfIhIh+hIQAYCQ1PUiehjpL\r\na=fingerprint:sha-256 D5:19:75:1D:FD:38:F8:3F:24:BC:98:7F:E7:0A:40:80:E4:2D:F3:2D:C9:5C:42:B7:34:A8:F9:33:89:4B:16:4A\r\na=setup:actpass\r\na=mid:video\r\na=extmap:2 urn:ietf:params:rtp-hdrext:toffset\r\na=extmap:3 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time\r\na=extmap:4 urn:3gpp:video-orientation\r\na=extmap:5 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01\r\na=extmap:6 http://www.webrtc.org/experiments/rtp-hdrext/playout-delay\r\na=sendrecv\r\na=rtcp-mux\r\na=rtcp-rsize\r\na=rtpmap:96 red/90000\r\na=rtpmap:98 ulpfec/90000\r\na=rtpmap:99 H264/90000\r\na=rtcp-fb:99 ccm fir\r\na=rtcp-fb:99 nack\r\na=rtcp-fb:99 nack pli\r\na=rtcp-fb:99 goog-remb\r\na=rtcp-fb:99 transport-cc\r\na=fmtp:99 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\na=rtpmap:97 rtx/90000\r\na=fmtp:97 apt=96\r\na=rtpmap:100 rtx/90000\r\na=fmtp:100 apt=99\r\na=ssrc-group:FID 861386681 1279155224\r\na=ssrc:861386681 cname:ZRjvL/OVqDHUGyr0\r\na=ssrc:861386681 msid:dc1214d7-b183-4ef9-a8d2-416278b274ac 1451f1f6-923c-4152-950d-02e457929696\r\na=ssrc:861386681 mslabel:dc1214d7-b183-4ef9-a8d2-416278b274ac\r\na=ssrc:861386681 label:1451f1f6-923c-4152-950d-02e457929696\r\na=ssrc:1279155224 cname:ZRjvL/OVqDHUGyr0\r\na=ssrc:1279155224 msid:dc1214d7-b183-4ef9-a8d2-416278b274ac 1451f1f6-923c-4152-950d-02e457929696\r\na=ssrc:1279155224 mslabel:dc1214d7-b183-4ef9-a8d2-416278b274ac\r\na=ssrc:1279155224 label:1451f1f6-923c-4152-950d-02e457929696\r\n" but got "v=0\r\no=- 6964394637269189587 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE video\r\na=msid-semantic: WMS dc1214d7-b183-4ef9-a8d2-416278b274ac\r\nm=video 58410 UDP/TLS/RTP/SAVPF 96 98 99 97 100\r\nc=IN IP4 17.202.88.219\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=candidate:998840395 1 udp 2122260223 17.202.88.219 58410 typ host generation 0 network-id 1 network-cost 50\r\na=ice-ufrag:H31i\r\na=ice-pwd:cBfIhIh+hIQAYCQ1PUiehjpL\r\na=fingerprint:sha-256 D5:19:75:1D:FD:38:F8:3F:24:BC:98:7F:E7:0A:40:80:E4:2D:F3:2D:C9:5C:42:B7:34:A8:F9:33:89:4B:16:4A\r\na=setup:actpass\r\na=mid:video\r\na=extmap:2 urn:ietf:params:rtp-hdrext:toffset\r\na=extmap:3 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time\r\na=extmap:4 urn:3gpp:video-orientation\r\na=extmap:5 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01\r\na=extmap:6 http://www.webrtc.org/experiments/rtp-hdrext/playout-delay\r\na=sendrecv\r\na=rtcp-mux\r\na=rtcp-rsize\r\na=rtpmap:96 red/90000\r\na=rtpmap:98 ulpfec/90000\r\na=rtpmap:99 H264/90000\r\na=rtcp-fb:99 ccm fir\r\na=rtcp-fb:99 nack\r\na=rtcp-fb:99 nack pli\r\na=rtcp-fb:99 goog-remb\r\na=rtcp-fb:99 transport-cc\r\na=fmtp:99 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\na=rtpmap:97 rtx/90000\r\na=fmtp:97 apt=96\r\na=rtpmap:100 rtx/90000\r\na=fmtp:100 apt=99\r\na=ssrc-group:FID 861386681 1279155224\r\na=ssrc:861386681 cname:ZRjvL/OVqDHUGyr0\r\na=ssrc:861386681 msid:dc1214d7-b183-4ef9-a8d2-416278b274ac 1451f1f6-923c-4152-950d-02e457929696\r\na=ssrc:861386681 mslabel:dc1214d7-b183-4ef9-a8d2-416278b274ac\r\na=ssrc:861386681 label:1451f1f6-923c-4152-950d-02e457929696\r\na=ssrc:1279155224 cname:ZRjvL/OVqDHUGyr0\r\na=ssrc:1279155224 msid:dc1214d7-b183-4ef9-a8d2-416278b274ac 1451f1f6-923c-4152-950d-02e457929696\r\na=ssrc:1279155224 mslabel:dc1214d7-b183-4ef9-a8d2-416278b274ac\r\na=ssrc:1279155224 label:1451f1f6-923c-4152-950d-02e457929696\r\n"

[Ryan Haddad]

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/213729

[youenn fablet]

Created attachment 306174 [details]
Patch

[Build Bot]

Comment on attachment 306174 [details]
Patch

Attachment 306174 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3472420

New failing tests:
webrtc/datachannel/basic.html

[Build Bot]

Created attachment 306176 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 306195 [details]
Patch

[Eric Carlson]

Comment on attachment 306195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306195&action=review

> Source/WebCore/testing/Internals.idl:461
> +    [Conditional=WEB_RTC] void setEnumeratingAllNetworkInterfaces(boolean enabled);

Nit: "setEnumeratingAllNetworkInterfacesEnabled" might be slightly clearer.

[youenn fablet]

Created attachment 306219 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 306219 [details]
Patch for landing

Rejecting attachment 306219 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 306219, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3473999

[youenn fablet]

Created attachment 306224 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 306224 [details]
Patch for landing

Clearing flags on attachment: 306224

Committed r214913: <http://trac.webkit.org/changeset/214913>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.