Bug 169466

Summary: Add test for expected fallback behavior between stroke-width and -webkit-text-stroke-width.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jonlee, lforschler, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Per Arne Vollan
Reported 2017-03-10 05:58:38 PST
Now that we have added support for stroke-width, we should have a test for expected fallback behavior between stroke-width and -webkit-text-stroke-width.
Attachments
Patch (3.22 KB, patch)
2017-03-10 06:42 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.52 KB, patch)
2017-03-13 06:26 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.80 KB, patch)
2017-03-14 01:34 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-03-10 06:42:21 PST
Created attachment 304041 [details] Patch
Per Arne Vollan
Comment 2 2017-03-13 06:26:50 PDT
Created attachment 304253 [details] Patch
Jon Lee
Comment 3 2017-03-13 12:21:41 PDT
Comment on attachment 304253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304253&action=review > LayoutTests/ChangeLog:10 > + When stroke-width is not specified, we fall back to -webkit-text-stroke-width. What about inline "-webkit-text-stroke-width" against a CSS rule of "stroke-width"?
Per Arne Vollan
Comment 4 2017-03-14 01:34:43 PDT
Created attachment 304368 [details] Patch
Per Arne Vollan
Comment 5 2017-03-14 01:36:33 PDT
(In reply to comment #3) > Comment on attachment 304253 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304253&action=review > > > LayoutTests/ChangeLog:10 > > + When stroke-width is not specified, we fall back to -webkit-text-stroke-width. > > What about inline "-webkit-text-stroke-width" against a CSS rule of > "stroke-width"? In this case, stroke-width is used.
WebKit Commit Bot
Comment 6 2017-04-01 22:28:57 PDT
Comment on attachment 304368 [details] Patch Clearing flags on attachment: 304368 Committed r214725: <http://trac.webkit.org/changeset/214725>
WebKit Commit Bot
Comment 7 2017-04-01 22:28:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.