Bug 169411

Summary: [Modern Media Controls] Controls are not visible in fullscreen without the controls attribute
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch for landing none

Antoine Quint
Reported 2017-03-09 05:18:51 PST
We should enforce controls in fullscreen when the controls attribute is not specified.
Attachments
Patch (5.88 KB, patch)
2017-03-09 05:22 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (12.29 MB, application/zip)
2017-03-09 07:06 PST, Build Bot 		no flags
Details
Patch for landing (10.35 KB, patch)
2017-03-09 07:19 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-03-09 05:19:03 PST
<rdar://problem/30931724>
Antoine Quint
Comment 2 2017-03-09 05:22:38 PST
Created attachment 303908 [details] Patch
Eric Carlson
Comment 3 2017-03-09 06:59:40 PST
Comment on attachment 303908 [details] Patch as discussed on IRC, we should also have a test to make sure default controls are not shown when a parent of the <video> is the fullscreen element
Antoine Quint
Comment 4 2017-03-09 07:04:44 PST
(In reply to comment #3) > as discussed on IRC, we should also have a test to make sure default > controls are not shown when a parent of the <video> is the fullscreen element Agreed, will add one when landing.
Build Bot
Comment 5 2017-03-09 07:06:26 PST
Comment on attachment 303908 [details] Patch Attachment 303908 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3276264 New failing tests: media/modern-media-controls/fullscreen-support/fullscreen-support-force-controls.html
Build Bot
Comment 6 2017-03-09 07:06:29 PST
Created attachment 303917 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Antoine Quint
Comment 7 2017-03-09 07:19:39 PST
Created attachment 303918 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-03-09 08:00:02 PST
Comment on attachment 303918 [details] Patch for landing Clearing flags on attachment: 303918 Committed r213640: <http://trac.webkit.org/changeset/213640>
WebKit Commit Bot
Comment 9 2017-03-09 08:00:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.