Bug 169410

Summary: Simple line layout: Add top level pagination support.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch none

alan
Reported 2017-03-09 05:01:43 PST
rdar://problem/28536227
Attachments
Patch (12.00 KB, patch)
2017-03-09 05:20 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
Patch (12.16 KB, patch)
2017-03-09 05:54 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2017-03-09 05:20:38 PST
Created attachment 303907 [details] Patch
Antti Koivisto
Comment 2 2017-03-09 05:24:58 PST
Comment on attachment 303907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303907&action=review > Source/WebCore/rendering/SimpleLineLayoutPagination.cpp:101 > + if ((!lineBreakIndex && line.height < flow.pageLogicalHeightForOffset(line.top)) > + || (!style.hasAutoOrphans() && style.orphans() > (short)lineBreakIndex)) { This might be more readable with some informatively named bool variables.
alan
Comment 3 2017-03-09 05:54:50 PST
Created attachment 303914 [details] Patch
WebKit Commit Bot
Comment 4 2017-03-09 07:25:15 PST
Comment on attachment 303914 [details] Patch Clearing flags on attachment: 303914 Committed r213639: <http://trac.webkit.org/changeset/213639>
WebKit Commit Bot
Comment 5 2017-03-09 07:25:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.