Bug 169392

Summary: Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix Mac/GTK builds
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2017-03-08 16:24:42 PST
Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
Attachments
Patch (20.18 KB, patch)
2017-03-08 16:54 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix Mac/GTK builds (21.96 KB, patch)
2017-03-08 17:16 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (22.17 KB, patch)
2017-03-08 20:36 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-03-08 16:54:00 PST
Created attachment 303866 [details] Patch
WebKit Commit Bot
Comment 2 2017-03-08 16:56:59 PST
Attachment 303866 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1155: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1157: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Wenson Hsieh
Comment 3 2017-03-08 17:16:21 PST
Created attachment 303871 [details] Fix Mac/GTK builds
WebKit Commit Bot
Comment 4 2017-03-08 17:17:50 PST
Attachment 303871 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1155: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1157: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Wenson Hsieh
Comment 5 2017-03-08 20:36:47 PST
Created attachment 303893 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-03-08 21:16:24 PST
Comment on attachment 303893 [details] Patch for landing Clearing flags on attachment: 303893 Committed r213627: <http://trac.webkit.org/changeset/213627>
Note You need to log in before you can comment on or make changes to this bug.