Bug 169366

Summary: WebGPU: Backend - hosting WebGPU layers
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: billmartinnn, dino, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 167952    
Attachments:
Description Flags
Patch
none
Patch dino: review+

Dean Jackson
Reported 2017-03-08 13:24:00 PST
Implement local and remote hosting of WebGPULayer
Attachments
Patch (5.16 KB, patch)
2017-03-13 00:06 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (5.19 KB, patch)
2017-03-13 00:08 PDT, Jon Lee 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2017-03-08 13:31:08 PST
<rdar://problem/30928735>
Jon Lee
Comment 2 2017-03-13 00:06:54 PDT
Created attachment 304233 [details] Patch
Jon Lee
Comment 3 2017-03-13 00:08:11 PDT
Created attachment 304234 [details] Patch
Dean Jackson
Comment 4 2017-03-13 00:13:48 PDT
Comment on attachment 304234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304234&action=review > Source/WebCore/ChangeLog:19 > + (WebCore::canvasCompositingStrategy): WebGPU canvas shoudl return CanvasAsLayerContents. Typo: should > Source/WebCore/html/canvas/WebGPURenderingContext.cpp:77 > Document& document = canvas.document(); > Frame* frame = document.frame(); > if (!frame) > return nullptr; This can be removed for now. > Source/WebCore/rendering/RenderLayerBacking.cpp:84 > - if (context->is3d()) > + if (context->is3d() || context->isGPU()) Should this be guarded with ENABLE(WEBGPU)?
Jon Lee
Comment 5 2017-03-13 00:18:44 PDT
Committed r213783: <http://trac.webkit.org/changeset/213783>
Jon Lee
Comment 6 2017-03-13 00:19:01 PDT
Comment on attachment 304234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304234&action=review >> Source/WebCore/ChangeLog:19 >> + (WebCore::canvasCompositingStrategy): WebGPU canvas shoudl return CanvasAsLayerContents. > > Typo: should Done. >> Source/WebCore/html/canvas/WebGPURenderingContext.cpp:77 >> return nullptr; > > This can be removed for now. Done. >> Source/WebCore/rendering/RenderLayerBacking.cpp:84 >> + if (context->is3d() || context->isGPU()) > > Should this be guarded with ENABLE(WEBGPU)? Separated this out and wrapped in ENABLE.
Note You need to log in before you can comment on or make changes to this bug.