Bug 169366

Summary: WebGPU: Backend - hosting WebGPU layers
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: billmartinnn, dino, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 167952    
Attachments:
Description Flags
Patch
none
Patch dino: review+

Description Dean Jackson 2017-03-08 13:24:00 PST
Implement local and remote hosting of WebGPULayer
Comment 1 Dean Jackson 2017-03-08 13:31:08 PST
<rdar://problem/30928735>
Comment 2 Jon Lee 2017-03-13 00:06:54 PDT
Created attachment 304233 [details]
Patch
Comment 3 Jon Lee 2017-03-13 00:08:11 PDT
Created attachment 304234 [details]
Patch
Comment 4 Dean Jackson 2017-03-13 00:13:48 PDT
Comment on attachment 304234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304234&action=review

> Source/WebCore/ChangeLog:19
> +        (WebCore::canvasCompositingStrategy): WebGPU canvas shoudl return CanvasAsLayerContents.

Typo: should

> Source/WebCore/html/canvas/WebGPURenderingContext.cpp:77
>      Document& document = canvas.document();
>      Frame* frame = document.frame();
>      if (!frame)
>          return nullptr;

This can be removed for now.

> Source/WebCore/rendering/RenderLayerBacking.cpp:84
> -    if (context->is3d())
> +    if (context->is3d() || context->isGPU())

Should this be guarded with ENABLE(WEBGPU)?
Comment 5 Jon Lee 2017-03-13 00:18:44 PDT
Committed r213783: <http://trac.webkit.org/changeset/213783>
Comment 6 Jon Lee 2017-03-13 00:19:01 PDT
Comment on attachment 304234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304234&action=review

>> Source/WebCore/ChangeLog:19
>> +        (WebCore::canvasCompositingStrategy): WebGPU canvas shoudl return CanvasAsLayerContents.
> 
> Typo: should

Done.

>> Source/WebCore/html/canvas/WebGPURenderingContext.cpp:77
>>          return nullptr;
> 
> This can be removed for now.

Done.

>> Source/WebCore/rendering/RenderLayerBacking.cpp:84
>> +    if (context->is3d() || context->isGPU())
> 
> Should this be guarded with ENABLE(WEBGPU)?

Separated this out and wrapped in ENABLE.