Bug 169363

Summary: CSS Multicolumn should not clip columns horizontally
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews116 for mac-elcapitan
none
Archive of layout-test-results from ews121 for ios-simulator-wk2 none

Description Dave Hyatt 2017-03-08 11:41:55 PST
CSS Multicolumn should not clip columns horizontally
Comment 1 Dave Hyatt 2017-03-08 11:43:52 PST
Created attachment 303823 [details]
Patch
Comment 2 Build Bot 2017-03-08 12:48:17 PST
Comment on attachment 303823 [details]
Patch

Attachment 303823 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3268367

New failing tests:
imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht
imported/w3c/css/css-multicol-1/multicol-span-none-001.xht
imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht
imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht
Comment 3 Build Bot 2017-03-08 12:48:20 PST
Created attachment 303827 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-03-08 12:51:23 PST
Comment on attachment 303823 [details]
Patch

Attachment 303823 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3268377

New failing tests:
imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht
imported/w3c/css/css-multicol-1/multicol-span-none-001.xht
imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht
imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht
Comment 5 Build Bot 2017-03-08 12:51:26 PST
Created attachment 303828 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-03-08 12:57:04 PST
Comment on attachment 303823 [details]
Patch

Attachment 303823 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3268368

New failing tests:
imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht
imported/w3c/css/css-multicol-1/multicol-span-none-001.xht
imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht
imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht
Comment 7 Build Bot 2017-03-08 12:57:07 PST
Created attachment 303830 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-03-08 13:03:23 PST
Comment on attachment 303823 [details]
Patch

Attachment 303823 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3268385

New failing tests:
imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht
imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht
imported/w3c/css/css-multicol-1/multicol-span-none-001.xht
imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht
imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht
Comment 9 Build Bot 2017-03-08 13:03:26 PST
Created attachment 303831 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Dave Hyatt 2017-03-08 13:12:32 PST
Landed in r213593. I just removed the 6 imported tests, as they rely on clipping to establish the correct behavior and are imported from a version of the spec that has now changed incompatibly.