Bug 169363

Summary:

CSS Multicolumn should not clip columns horizontally

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

New Bugs

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none

Dave Hyatt

Reported 2017-03-08 11:41:55 PST

CSS Multicolumn should not clip columns horizontally

Attachments
Patch (9.31 KB, patch) 2017-03-08 11:43 PST, Dave Hyatt	sam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.00 MB, application/zip) 2017-03-08 12:48 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (882.67 KB, application/zip) 2017-03-08 12:51 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.73 MB, application/zip) 2017-03-08 12:57 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (913.34 KB, application/zip) 2017-03-08 13:03 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2017-03-08 11:43:52 PST

Created attachment 303823 [details] Patch

Build Bot

Comment 2 2017-03-08 12:48:17 PST

Comment on attachment 303823 [details] Patch Attachment 303823 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3268367 New failing tests: imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht imported/w3c/css/css-multicol-1/multicol-span-none-001.xht imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht

Build Bot

Comment 3 2017-03-08 12:48:20 PST

Created attachment 303827 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-03-08 12:51:23 PST

Comment on attachment 303823 [details] Patch Attachment 303823 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3268377 New failing tests: imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht imported/w3c/css/css-multicol-1/multicol-span-none-001.xht imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht

Build Bot

Comment 5 2017-03-08 12:51:26 PST

Created attachment 303828 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-03-08 12:57:04 PST

Comment on attachment 303823 [details] Patch Attachment 303823 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3268368 New failing tests: imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht imported/w3c/css/css-multicol-1/multicol-span-none-001.xht imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht

Build Bot

Comment 7 2017-03-08 12:57:07 PST

Created attachment 303830 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-03-08 13:03:23 PST

Comment on attachment 303823 [details] Patch Attachment 303823 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3268385 New failing tests: imported/w3c/css/css-multicol-1/multicol-count-computed-005.xht imported/w3c/css/css-multicol-1/multicol-block-clip-001.xht imported/w3c/css/css-multicol-1/multicol-block-clip-002.xht imported/w3c/css/css-multicol-1/multicol-span-none-001.xht imported/w3c/css/css-multicol-1/multicol-height-block-child-001.xht imported/w3c/css/css-multicol-1/multicol-count-computed-003.xht

Build Bot

Comment 9 2017-03-08 13:03:26 PST

Created attachment 303831 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Dave Hyatt

Comment 10 2017-03-08 13:12:32 PST

Landed in r213593. I just removed the 6 imported tests, as they rely on clipping to establish the correct behavior and are imported from a version of the spec that has now changed incompatibly.

Note You need to log in before you can comment on or make changes to this bug.