| Summary: | [Gtk] webkitgtk/autotools should use WebKitGtk instead of WebKit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jan Alonzo <jmalonzo> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alp, christian | ||||
| Priority: | P3 | Keywords: | Gtk | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Jan Alonzo
2008-01-18 14:20:57 PST
Created attachment 18534 [details]
webkitgtk/autotools should use WebKitGtk in its include path
Comment on attachment 18534 [details]
webkitgtk/autotools should use WebKitGtk in its include path
This change isn't wrong but I'd rather not change things again until we fix the header paths and the pkg-config package name for good.
If this issue is actually causing a problem for someone, please re-mark it for review and I'll land it, but otherwise I think it's redundant.
alp, now that header paths and pkg-config changes are in, is this still something we want to consider for the gtk+ port? thanks. Yeah. (In reply to comment #3) > alp, now that header paths and pkg-config changes are in, is this still > something we want to consider for the gtk+ port? thanks. > Yeah. We still need to rename the top-level include directory and library name to something like webkit-1.0 For the library renaming we should first have the WebCore build split out from the WebKit build, so there are separate libwebcore and libwebkit_1_0 automake targets. alp, do you think a unified top-level /usr/include/WebKit is something the other ports might want as well? (e.g, for gtk - WebKit/gtk/webkit, qt - WebKit/qt/, wx - WebKit/wx, etc...) (In reply to comment #5) > alp, do you think a unified top-level /usr/include/WebKit is something the > other ports might want as well? (e.g, for gtk - WebKit/gtk/webkit, qt - > WebKit/qt/, wx - WebKit/wx, etc...) > Nope. The APIs are each different, have separate release schedules etc. No sense in grouping them together. We hoped early on to share a base JSCore but that isn't going to happen soon either. So what we have now is the best we can do (apart from renaming as I mentioned previously). This bug's already been fixed by http://trac.webkit.org/projects/webkit/changeset/30702 |