Bug 169266

Summary:

REGRESSION (r213412): JPEG premultiplication tests fail under GuardMalloc

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jonlee, mmaxfield, saam, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andy Estes 2017-03-06 23:52:12 PST

REGRESSION (r213412): JPEG premultiplication tests fail under GuardMalloc

Comment 1 Andy Estes 2017-03-07 00:13:18 PST

Created attachment 303633 [details]
Patch

Comment 2 Tim Horton 2017-03-07 00:59:35 PST

Comment on attachment 303633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303633&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:530
> +        premultipliedData = getPremultipliedImageData(IntRect(IntPoint(0, 0), logicalSize()));

Can drop the 0, 0

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:560
> +static RetainPtr<CFDataRef> cfData(const ImageData& source, const String& mimeType, std::optional<double> quality)

This does seem like a better plan.

Comment 3 Andy Estes 2017-03-07 01:10:22 PST

Created attachment 303636 [details]
Patch

Comment 4 WebKit Commit Bot 2017-03-07 01:51:21 PST

Comment on attachment 303636 [details]
Patch

Clearing flags on attachment: 303636

Committed r213508: <http://trac.webkit.org/changeset/213508>

Comment 5 WebKit Commit Bot 2017-03-07 01:51:25 PST

All reviewed patches have been landed.  Closing bug.