Bug 169263

Summary: Update ReadMe.md to use directory format for backing up & restoring the database
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, kling, koivisto, rniwa, slewis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Updates ReadMe.md
none
Updates ReadMe.md none

Description Ryosuke Niwa 2017-03-06 22:04:20 PST 
Use pg_dump's directory format to more efficiently make backups.
Comment 1 Ryosuke Niwa 2017-03-06 22:07:40 PST 
Created attachment 303622 [details]
Updates ReadMe.md
Comment 2 Ryosuke Niwa 2017-03-06 22:20:20 PST 
Created attachment 303624 [details]
Updates ReadMe.md
Comment 3 Joseph Pecoraro 2017-03-07 14:55:32 PST 
Comment on attachment 303624 [details]
Updates ReadMe.md

View in context: https://bugs.webkit.org/attachment.cgi?id=303624&action=review

rs=me

> Websites/perf.webkit.org/ReadMe.md:128
> +- Making the fullbackup of the database: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_dump -h localhost webkit-perf-db --format=directory --file=<path to backup directory> --jobs=4 --no-owner --compress=7`

Is <path to backup directory> treated as an HTML tag by markdown? In any case, such text pre-exists this change.
Comment 4 Ryosuke Niwa 2017-03-07 15:20:39 PST 
(In reply to comment #3)
> Comment on attachment 303624 [details]
> Updates ReadMe.md
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303624&action=review
> 
> rs=me
> 
> > Websites/perf.webkit.org/ReadMe.md:128
> > +- Making the fullbackup of the database: `/Applications/Server.app/Contents/ServerRoot/usr/bin/pg_dump -h localhost webkit-perf-db --format=directory --file=<path to backup directory> --jobs=4 --no-owner --compress=7`
> 
> Is <path to backup directory> treated as an HTML tag by markdown? In any
> case, such text pre-exists this change.

I don't think so at least when it's wrapped in ``.
Comment 5 Ryosuke Niwa 2017-03-07 15:21:54 PST 
Comment on attachment 303624 [details]
Updates ReadMe.md

Clearing flags on attachment: 303624

Committed r213548: <http://trac.webkit.org/changeset/213548>
Comment 6 Ryosuke Niwa 2017-03-07 15:22:00 PST 
All reviewed patches have been landed.  Closing bug.