Summary: | Well-known variations should clamp to the values listed in the @font-face block | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | commit-queue, dino, jonlee, mmaxfield, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||
Bug Blocks: | 162815 | ||||||||||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2017-03-06 21:17:30 PST
Created attachment 305824 [details]
Needs tests
Created attachment 306651 [details]
CSSFontFace::m_fontSelectionCapabilities needs to be able to be optional in CSSFontFace::font()
Created attachment 306856 [details]
Needs tests
Created attachment 306862 [details]
Patch
Created attachment 306864 [details]
Patch
Created attachment 306885 [details]
Patch
Created attachment 306886 [details]
Patch
Created attachment 306888 [details]
Patch
Comment on attachment 306888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306888&action=review > Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:319 > + uint32_t uniqueValue() const > + { > + return minimum.rawValue() << 16 | maximum.rawValue(); > + } > + Is that really unique? (In reply to Dean Jackson from comment #10) > Comment on attachment 306888 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306888&action=review > > > Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:319 > > + uint32_t uniqueValue() const > > + { > > + return minimum.rawValue() << 16 | maximum.rawValue(); > > + } > > + > > Is that really unique? This function maps two 16-bit numbers to a unique 32-bit number, so yes. Comment on attachment 306888 [details] Patch Clearing flags on attachment: 306888 Committed r215287: <http://trac.webkit.org/changeset/215287> All reviewed patches have been landed. Closing bug. |