Bug 169260

Summary: Well-known variations should clamp to the values listed in the @font-face block
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162815    
Attachments:
Description Flags
Needs tests
none
CSSFontFace::m_fontSelectionCapabilities needs to be able to be optional in CSSFontFace::font()
none
Needs tests
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Myles C. Maxfield 2017-03-06 21:17:30 PST
See https://github.com/w3c/csswg-drafts/issues/782
Comment 1 Myles C. Maxfield 2017-03-29 20:08:47 PDT
Created attachment 305824 [details]
Needs tests
Comment 2 Radar WebKit Bug Importer 2017-04-07 19:17:26 PDT
<rdar://problem/31516360>
Comment 3 Myles C. Maxfield 2017-04-09 21:59:23 PDT
Created attachment 306651 [details]
CSSFontFace::m_fontSelectionCapabilities needs to be able to be optional in CSSFontFace::font()
Comment 4 Myles C. Maxfield 2017-04-11 14:55:26 PDT
Created attachment 306856 [details]
Needs tests
Comment 5 Myles C. Maxfield 2017-04-11 15:19:05 PDT
Created attachment 306862 [details]
Patch
Comment 6 Myles C. Maxfield 2017-04-11 15:21:38 PDT
Created attachment 306864 [details]
Patch
Comment 7 Myles C. Maxfield 2017-04-11 20:50:51 PDT
Created attachment 306885 [details]
Patch
Comment 8 Myles C. Maxfield 2017-04-11 21:00:56 PDT
Created attachment 306886 [details]
Patch
Comment 9 Myles C. Maxfield 2017-04-11 21:51:01 PDT
Created attachment 306888 [details]
Patch
Comment 10 Dean Jackson 2017-04-12 13:23:24 PDT
Comment on attachment 306888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306888&action=review

> Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:319
> +    uint32_t uniqueValue() const
> +    {
> +        return minimum.rawValue() << 16 | maximum.rawValue();
> +    }
> +

Is that really unique?
Comment 11 Myles C. Maxfield 2017-04-12 13:24:18 PDT
(In reply to Dean Jackson from comment #10)
> Comment on attachment 306888 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306888&action=review
> 
> > Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:319
> > +    uint32_t uniqueValue() const
> > +    {
> > +        return minimum.rawValue() << 16 | maximum.rawValue();
> > +    }
> > +
> 
> Is that really unique?

This function maps two 16-bit numbers to a unique 32-bit number, so yes.
Comment 12 WebKit Commit Bot 2017-04-12 13:54:08 PDT
Comment on attachment 306888 [details]
Patch

Clearing flags on attachment: 306888

Committed r215287: <http://trac.webkit.org/changeset/215287>
Comment 13 WebKit Commit Bot 2017-04-12 13:54:10 PDT
All reviewed patches have been landed.  Closing bug.