Bug 169188

Summary: Rename CustomProtocolFoo to LegacyCustomProtocolFoo
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, buildbot, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan
none
Patch none

Description Brady Eidson 2017-03-05 14:20:56 PST 
Rename CustomProtocolFoo to LegacyCustomProtocolFoo
Comment 1 Brady Eidson 2017-03-05 14:42:16 PST 
Created attachment 303466 [details]
Patch
Comment 2 Andy Estes 2017-03-05 14:46:25 PST 
Comment on attachment 303466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303466&action=review

> Source/WebKit2/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in:23
> +messages -> CustomProtocolManagerProxy {

LegacyCustomProtocolManagerProxy?
Comment 3 Brady Eidson 2017-03-05 14:52:22 PST 
Created attachment 303468 [details]
Patch
Comment 4 Brady Eidson 2017-03-05 15:04:18 PST 
Created attachment 303469 [details]
Patch
Comment 5 Brady Eidson 2017-03-05 15:15:06 PST 
Created attachment 303472 [details]
Patch
Comment 6 Brady Eidson 2017-03-05 15:21:50 PST 
Created attachment 303473 [details]
Patch
Comment 7 Brady Eidson 2017-03-05 15:31:47 PST 
Created attachment 303475 [details]
Patch
Comment 8 Brady Eidson 2017-03-05 15:40:39 PST 
Created attachment 303476 [details]
Patch
Comment 9 Brady Eidson 2017-03-05 15:52:15 PST 
Created attachment 303478 [details]
Patch
Comment 10 Brady Eidson 2017-03-05 15:56:30 PST 
Created attachment 303479 [details]
Patch
Comment 11 Brady Eidson 2017-03-05 16:09:39 PST 
Created attachment 303481 [details]
Patch
Comment 12 Brady Eidson 2017-03-05 16:26:09 PST 
Created attachment 303483 [details]
Patch
Comment 13 Brady Eidson 2017-03-05 16:35:31 PST 
Created attachment 303484 [details]
Patch
Comment 14 Build Bot 2017-03-05 17:16:00 PST 
Comment on attachment 303484 [details]
Patch

Attachment 303484 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3249267

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html
Comment 15 Build Bot 2017-03-05 17:16:03 PST 
Created attachment 303488 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 16 Brady Eidson 2017-03-05 18:10:49 PST 
Created attachment 303491 [details]
Patch
Comment 17 WebKit Commit Bot 2017-03-05 18:53:35 PST 
Comment on attachment 303491 [details]
Patch

Clearing flags on attachment: 303491

Committed r213441: <http://trac.webkit.org/changeset/213441>
Comment 18 WebKit Commit Bot 2017-03-05 18:53:42 PST 
All reviewed patches have been landed.  Closing bug.