Summary: | Add support for relative pathnames to JSC config files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | clopez, commit-queue, darin, keith_miller, mark.lam, mcatanzaro, saam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Saboff
2017-03-03 16:11:02 PST
Created attachment 303355 [details]
Patch
Comment on attachment 303355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303355&action=review r=me > Source/JavaScriptCore/runtime/ConfigFile.cpp:434 > + if (sizeof(filenameBuffer) - 1 > pathnameLength + shouldAddPathSeparator) { Why not >=? (In reply to comment #3) > > Source/JavaScriptCore/runtime/ConfigFile.cpp:434 > > + if (sizeof(filenameBuffer) - 1 > pathnameLength + shouldAddPathSeparator) { > > Why not >=? I think you're right, >= is fine. I made that change. Committed r213399: <http://trac.webkit.org/changeset/213399> Committed r213416: <http://trac.webkit.org/changeset/213416> I don’t think we need an #if around include of <unistd.h>. Do we compile on any platform that does not have a header by that name? Surely Windows does not have unistd.h? Is that wrong? (In reply to comment #8) > Surely Windows does not have unistd.h? Is that wrong? I had though we had some sort of compatibility version of <unistd.h> for Windows, but looking at the rest of our code it seems that we don’t. (I see an unguarded include of that header in WebProcess.cpp, but I think that’s in code we don’t compile for Windows. I think there used to be a compatibility version of the header inside ANGLE, but not any more and we wouldn’t have wanted to rely on it anyway. Instead we include <unistd.h> in a few different places, each time with a different #if. So I guess this makes it no worse.) |