Bug 169147

Summary: Further optimize checkWebRTCAvailability
Product: WebKit Reporter: Jon Lee <jonlee>
Component: New BugsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, joepeck, mitz, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168913
Attachments:
Description Flags
Patch
none
Moving the routine within LIBWEBRTC flag none

Jon Lee
Reported 2017-03-03 14:00:02 PST
Further optimization on b168913 as suggested by Dan: > This check can be implemented by null-checking any of the symbols known to be exported from the dylib, which is a single branch. An implementation that involves a function call still seems unoptimal.
Attachments
Patch (2.23 KB, patch)
2017-03-25 18:02 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Moving the routine within LIBWEBRTC flag (2.30 KB, patch)
2017-03-25 23:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-03-24 16:14:21 PDT
I'll go other it this week-end if nobody gets it before.
youenn fablet
Comment 2 2017-03-25 18:02:46 PDT
Created attachment 305409 [details] Patch
youenn fablet
Comment 3 2017-03-25 18:04:14 PDT
Might be related to radar://31242422
youenn fablet
Comment 4 2017-03-25 23:30:28 PDT
Created attachment 305415 [details] Moving the routine within LIBWEBRTC flag
Radar WebKit Bug Importer
Comment 5 2017-03-26 11:15:46 PDT
<rdar://problem/31263660>
WebKit Commit Bot
Comment 6 2017-03-27 10:48:25 PDT
Comment on attachment 305415 [details] Moving the routine within LIBWEBRTC flag Clearing flags on attachment: 305415 Committed r214418: <http://trac.webkit.org/changeset/214418>
WebKit Commit Bot
Comment 7 2017-03-27 10:48:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.