Bug 169130

Summary: [GTK] Ensure WebKitWebView always have a user content manager
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 166680    
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2017-03-03 05:52:57 PST
User content manager is a construct only property, so if not set by the user the web view doesn't have any. We can create a default one, like we do for settings, when user didn't provide one.
Attachments
Patch (2.07 KB, patch)
2017-03-03 05:55 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-03-03 05:55:39 PST
Created attachment 303315 [details] Patch I need this for the new remote inspector, that uses a custom protocol page with user script messages.
WebKit Commit Bot
Comment 2 2017-03-03 05:57:20 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2017-03-03 08:02:05 PST
Comment on attachment 303315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303315&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2267 > * Returns: (transfer none): the #WebKitUserContentManager associated with the view So it's no longer (transfer none), then. Technically an introspection API break, but breakage should be minimal....
Carlos Garcia Campos
Comment 4 2017-03-03 08:49:24 PST
(In reply to comment #3) > Comment on attachment 303315 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=303315&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2267 > > * Returns: (transfer none): the #WebKitUserContentManager associated with the view > > So it's no longer (transfer none), then. Technically an introspection API > break, but breakage should be minimal.... Why not? the default user content manager is also owned by the web view, so this is still transfer none.
Michael Catanzaro
Comment 5 2017-03-03 08:57:53 PST
(In reply to comment #4) > Why not? the default user content manager is also owned by the web view, so > this is still transfer none. Ah, dumb, sorry. I confused (transfer none) with (allow none).
WebKit Commit Bot
Comment 6 2017-03-03 09:23:08 PST
Comment on attachment 303315 [details] Patch Clearing flags on attachment: 303315 Committed r213366: <http://trac.webkit.org/changeset/213366>
WebKit Commit Bot
Comment 7 2017-03-03 09:23:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.