Bug 169104

Summary: Move part of NetworkRTCProvider::close implementation in NetworkRTCProvider destructor
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2017-03-02 15:31:52 PST
It is safer to delete as many fields as possible in NetworkRTCPRovider destructor. We still need close so that we can cleanproperly rtc network thread related members by taking a ref of NetworkRTCPRovider.
Attachments
Patch (3.47 KB, patch)
2017-03-02 15:36 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.50 KB, patch)
2017-03-02 16:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-03-02 15:36:20 PST
Created attachment 303256 [details] Patch
Alex Christensen
Comment 2 2017-03-02 16:11:11 PST
Comment on attachment 303256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303256&action=review > Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp:74 > + stopResolver(identifier); mention in changelog
youenn fablet
Comment 3 2017-03-02 16:24:05 PST
Created attachment 303266 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-03-02 17:28:47 PST
Comment on attachment 303266 [details] Patch for landing Clearing flags on attachment: 303266 Committed r213330: <http://trac.webkit.org/changeset/213330>
WebKit Commit Bot
Comment 5 2017-03-02 17:28:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.