Bug 169104

Summary: Move part of NetworkRTCProvider::close implementation in NetworkRTCProvider destructor
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2017-03-02 15:31:52 PST 
It is safer to delete as many fields as possible in NetworkRTCPRovider destructor.
We still need close so that we can cleanproperly rtc network thread related members by taking a ref of NetworkRTCPRovider.
Comment 1 youenn fablet 2017-03-02 15:36:20 PST 
Created attachment 303256 [details]
Patch
Comment 2 Alex Christensen 2017-03-02 16:11:11 PST 
Comment on attachment 303256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303256&action=review

> Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp:74
> +        stopResolver(identifier);

mention in changelog
Comment 3 youenn fablet 2017-03-02 16:24:05 PST 
Created attachment 303266 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-03-02 17:28:47 PST 
Comment on attachment 303266 [details]
Patch for landing

Clearing flags on attachment: 303266

Committed r213330: <http://trac.webkit.org/changeset/213330>
Comment 5 WebKit Commit Bot 2017-03-02 17:28:51 PST 
All reviewed patches have been landed.  Closing bug.