Bug 169092

Summary:

Fix addressing mode for B3WasmAddress

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	fpizlo: review+

Keith Miller

Reported 2017-03-02 13:03:19 PST

Fix addressing mode for B3WasmAddress

Attachments
Patch (1.73 KB, patch) 2017-03-02 13:14 PST, Keith Miller	fpizlo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2017-03-02 13:14:21 PST

Created attachment 303228 [details] Patch

Mark Lam

Comment 2 2017-03-02 13:15:39 PST

Comment on attachment 303228 [details] Patch r=me

Filip Pizlo

Comment 3 2017-03-02 13:17:16 PST

Comment on attachment 303228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303228&action=review > Source/JavaScriptCore/ChangeLog:11 > + Fix the potential addressing modes for B3WasmAddress. ARM does not > + support a base + index*1 + offset addressing mode. I think when I > + read it the first time I assumed it would always work on both ARM > + and X86. While true for X86 it's not true for ARM. ARM totally supports base + index*1.

Filip Pizlo

Comment 4 2017-03-02 13:18:02 PST

Comment on attachment 303228 [details] Patch I get it now.

Keith Miller

Comment 5 2017-03-02 13:20:58 PST

Committed r213299: <http://trac.webkit.org/changeset/213299>

Note You need to log in before you can comment on or make changes to this bug.