Bug 169078

Summary: Implement stroke-miterlimit.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: CSSAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dino, eric.carlson, hyatt, jonlee, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
dino: review+
Patch none

Per Arne Vollan
Reported 2017-03-02 05:04:01 PST
Implement stroke-miterlimit, see https://drafts.fxtf.org/paint/.
Attachments
Patch (17.33 KB, patch)
2017-03-02 05:11 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (17.36 KB, patch)
2017-03-02 05:56 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (22.69 KB, patch)
2017-03-03 02:36 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (24.07 KB, patch)
2017-03-03 03:21 PST, Per Arne Vollan 		dino: review+
DetailsFormatted DiffDiff
Patch (24.92 KB, patch)
2017-04-03 05:16 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-03-02 05:11:58 PST
Created attachment 303192 [details] Patch
Per Arne Vollan
Comment 2 2017-03-02 05:56:24 PST
Created attachment 303194 [details] Patch
Alexey Proskuryakov
Comment 3 2017-03-02 14:52:14 PST
rdar://problem/30754816
Per Arne Vollan
Comment 4 2017-03-03 02:36:41 PST
Created attachment 303308 [details] Patch
Per Arne Vollan
Comment 5 2017-03-03 03:21:20 PST
Created attachment 303310 [details] Patch
Dave Hyatt
Comment 6 2017-03-31 14:58:02 PDT
Comment on attachment 303310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303310&action=review > Source/WebCore/rendering/TextPaintStyle.h:55 > + float miterLimit { 4 }; Seems like the value "4" needs to be a constant, since... > Source/WebCore/rendering/style/RenderStyle.h:1259 > + static float initialStrokeMiterLimit() { return 4; } .... you repeat 4 here.
Per Arne Vollan
Comment 7 2017-04-03 05:16:08 PDT
Created attachment 306072 [details] Patch
Per Arne Vollan
Comment 8 2017-04-03 06:59:13 PDT
Thanks for reviewing!
Per Arne Vollan
Comment 9 2017-04-03 06:59:37 PDT
Committed <https://trac.webkit.org/changeset/214787/webkit>.
Note You need to log in before you can comment on or make changes to this bug.