Bug 169070

Summary:

Don't keep dead resources in MemoryCache while under memory pressure.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

REOPENED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dbates, japhet, rniwa, ryanhaddad

Priority:

Keywords:

Performance

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for EWS	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none

Andreas Kling

Reported 2017-03-01 23:55:10 PST

Yep.

Attachments
Patch (1.77 KB, patch) 2017-03-02 00:00 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch for EWS (3.87 KB, patch) 2017-03-15 10:40 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (728.40 KB, application/zip) 2017-03-15 11:08 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (830.45 KB, application/zip) 2017-03-15 11:25 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (662.88 KB, application/zip) 2017-03-15 11:56 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2017-03-02 00:00:54 PST

Created attachment 303178 [details] Patch

WebKit Commit Bot

Comment 2 2017-03-02 01:02:37 PST

Comment on attachment 303178 [details] Patch Clearing flags on attachment: 303178 Committed r213274: <http://trac.webkit.org/changeset/213274>

WebKit Commit Bot

Comment 3 2017-03-02 01:02:42 PST

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 4 2017-03-02 15:58:51 PST

This change appears to have caused a flaky crash seen with memory/memory-pressure-simulation.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r213301%20(4134)/results.html

Ryan Haddad

Comment 5 2017-03-02 21:21:26 PST

Reverted r213274 for reason: This change caused flakiness with LayoutTest memory/memory-pressure-simulation.html Committed r213350: <http://trac.webkit.org/changeset/213350>

Andreas Kling

Comment 6 2017-03-15 10:40:36 PDT

Created attachment 304514 [details] Patch for EWS Okay, let's harden MemoryCache::remove() against being called with CachedResources that are not in the cache, as well as CachedResources that are cached, but not present in a session resources map. EWS, what do you think?

Build Bot

Comment 7 2017-03-15 11:08:46 PDT

Comment on attachment 304514 [details] Patch for EWS Attachment 304514 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3331624 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2017-03-15 11:08:53 PDT

Created attachment 304517 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-03-15 11:25:53 PDT

Comment on attachment 304514 [details] Patch for EWS Attachment 304514 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3331673 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2017-03-15 11:25:59 PDT

Created attachment 304518 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-03-15 11:56:25 PDT

Comment on attachment 304514 [details] Patch for EWS Attachment 304514 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3331732 Number of test failures exceeded the failure limit.

Build Bot

Comment 12 2017-03-15 11:56:34 PDT

Created attachment 304521 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Note You need to log in before you can comment on or make changes to this bug.