Bug 169063

Summary:

Add ability to read bindings test results

Product:

WebKit

Reporter:

Srinivasan Vijayaraghavan <webkit>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, glenn, webkit

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

169053

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Description Srinivasan Vijayaraghavan 2017-03-01 15:54:45 PST

Add ability to read bindings test results

Comment 1 Srinivasan Vijayaraghavan 2017-03-01 17:07:29 PST

Created attachment 303145 [details]
Patch

Comment 2 WebKit Commit Bot 2017-03-01 17:09:53 PST

Attachment 303145 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/net/bindingstestresults.py:39:  [BindingsTestResults.results_from_string] Class 'BindingsTestResults' has no 'parse_json_string' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py:26:  No name 'abstracttestresultsreader' in module 'webkitpy.tool.bot'  [pylint/E0611] [5]
ERROR: Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py:33:  [BindingsTestResultsReader.results] Instance of 'BindingsTestResultsReader' has no '_host' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py:33:  [BindingsTestResultsReader.results] Instance of 'BindingsTestResultsReader' has no '_results_directory' member  [pylint/E1101] [5]
ERROR: Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py:34:  [BindingsTestResultsReader.results] Instance of 'BindingsTestResultsReader' has no '_read_file_contents' member  [pylint/E1101] [5]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Srinivasan Vijayaraghavan 2017-03-01 17:12:31 PST

Style-queue thinks some methods are missing because the patch on bug 169053 is not landed yet.

Comment 4 Dean Johnson 2017-03-02 12:11:13 PST

Comment on attachment 303145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303145&action=review

LGTM; Please add the unit test(s) I mention below.

> Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py:38
> +        self.assertTrue(no_failures_results.all_passed())

Please add a test for success cases as well.

Comment 5 Srinivasan Vijayaraghavan 2017-03-02 14:54:33 PST

Created attachment 303248 [details]
Patch

Comment 6 WebKit Commit Bot 2017-03-02 16:09:19 PST

Comment on attachment 303248 [details]
Patch

Clearing flags on attachment: 303248

Committed r213321: <http://trac.webkit.org/changeset/213321>

Comment 7 WebKit Commit Bot 2017-03-02 16:09:23 PST

All reviewed patches have been landed.  Closing bug.