Bug 169053

Summary: Refactor test results classes in webkitpy to enable faster EWS iteration
Product: WebKit Reporter: Srinivasan Vijayaraghavan <webkit>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dbates, glenn, lforschler, webkit
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 169063    
Attachments:
Description Flags
Patch
none
Patch none

Srinivasan Vijayaraghavan
Reported 2017-03-01 13:32:47 PST
Patch incoming.
Attachments
Patch (12.23 KB, patch)
2017-03-01 13:35 PST, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Patch (12.69 KB, patch)
2017-03-02 13:53 PST, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Srinivasan Vijayaraghavan
Comment 1 2017-03-01 13:35:57 PST
Created attachment 303108 [details] Patch
Alexey Proskuryakov
Comment 2 2017-03-02 11:07:21 PST
Comment on attachment 303108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303108&action=review > Tools/Scripts/webkitpy/tool/bot/abstracttestresultsreader.py:37 > + except (IOError, KeyError): > + return None Can there be logging when this happens? I'm concerned that if the issue occurs, it may be hard to debug when the failure is silent.
Dean Johnson
Comment 3 2017-03-02 12:12:24 PST
Comment on attachment 303108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303108&action=review LGTM; Please add the unit test(s) mentioned below. > Tools/Scripts/webkitpy/common/net/abstracttestresults_unittest.py:37 > + self.assertEqual(None, AbstractTestResults.parse_json_string(invalid_json_v2)) Please add a succeeding unit test too.
Srinivasan Vijayaraghavan
Comment 4 2017-03-02 13:53:24 PST
Created attachment 303235 [details] Patch
WebKit Commit Bot
Comment 5 2017-03-02 14:44:57 PST
Comment on attachment 303235 [details] Patch Clearing flags on attachment: 303235 Committed r213306: <http://trac.webkit.org/changeset/213306>
WebKit Commit Bot
Comment 6 2017-03-02 14:45:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.