Bug 169047

Summary:

IsSmartPtr<WKRetainPtr<T>>::value should not be exported

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebKit2

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, juergen, mitz, thorton

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Description Aakash Jain 2017-03-01 11:23:26 PST

This symbol from UIProcess/API/cpp/WKRetainPtr.h is not used by other projects. No headers contains this symbol. We should not export this symbol.

Comment 1 Aakash Jain 2017-03-01 11:24:43 PST

Created attachment 303088 [details]
Proposed patch

Comment 2 Alexey Proskuryakov 2017-03-01 12:53:11 PST

The reason why this is needed is that this header is a private one, used by WebKit tools. But I don't think that there is any reason to have the symbol exported.

Comment 3 WebKit Commit Bot 2017-03-02 15:42:16 PST

Comment on attachment 303088 [details]
Proposed patch

Clearing flags on attachment: 303088

Committed r213312: <http://trac.webkit.org/changeset/213312>

Comment 4 WebKit Commit Bot 2017-03-02 15:42:20 PST

All reviewed patches have been landed.  Closing bug.